Unify the version string to be displayed on "About Chromium" dialog.

chrome/browser/ui/views/about_chrome_view.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_ABOUT_CHROME_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_ABOUT_CHROME_VIEW_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
@@ skipping 77 matching lines @@
   void UpdateStatus(GoogleUpdateUpgradeResult result,
                     GoogleUpdateErrorCode error_code);
 #endif
 
   Profile* profile_;
 
   // UI elements on the dialog.
   views::ImageView* about_dlg_background_logo_;
   views::Label* about_title_label_;
   views::Textfield* version_label_;
-  views::Textfield* os_version_label_;

[tony, 2011/06/14 18:56:31]

I suspect this is here for a reason and we shouldn't remove it.  It probably
makes it easier for bug reporters to include the OS version.

[haraken1, 2011/06/15 04:20:41]

I think it is OK to remove |os_version_label_| since in this patch the OS name
is included in |version_label_|. Previously, Windows shows the OS name in
|os_version_label_|, which is displayed just under |version_label_|. Linux shows
the OS name in |version_label_|. Mac shows no OS name. Thus, my intent is to
unify their formats, specifically, all version information is included in
|version_label_| so that people can copy and paste it in one line. For this
reason, I guess that |os_version_label_| can be removed from here. 

   views::Label* copyright_label_;
   views::Label* main_text_label_;
   int main_text_label_height_;
   views::Link* chromium_url_;
   gfx::Rect chromium_url_rect_;
   views::Link* open_source_url_;
   gfx::Rect open_source_url_rect_;
   views::Link* terms_of_service_url_;
   gfx::Rect terms_of_service_url_rect_;
   // UI elements we add to the parent view.
@@ skipping 19 matching lines @@
   std::wstring main_label_chunk5_;
   // Determines the order of the two links we draw in the main label.
   bool chromium_url_appears_first_;
 
 #if defined(OS_WIN)
   // The class that communicates with Google Update to find out if an update is
   // available and asks it to start an upgrade.
   scoped_refptr<GoogleUpdate> google_updater_;
 #endif
 
-  // Our current version.
-  std::string current_version_;
-
-  // Additional information about the version (channel and build number).
-  std::string version_details_;
-
   // The version Google Update reports is available to us.
   std::wstring new_version_available_;
 
   // Whether text direction is left-to-right or right-to-left.
   bool text_direction_is_rtl_;
 
   DISALLOW_COPY_AND_ASSIGN(AboutChromeView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_ABOUT_CHROME_VIEW_H_