Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2622)

Unified Diff: chrome/browser/history/history.h

Issue 7104088: Changed typed url sync to no longer modify typed/visit_count. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated per review comments. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/history/history_backend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history.h
diff --git a/chrome/browser/history/history.h b/chrome/browser/history/history.h
index 70436cc7808ee9f1e5098745d52e6f18f3ed067a..99af5275927f783b6371fe3930cf08237c1f1be8 100644
--- a/chrome/browser/history/history.h
+++ b/chrome/browser/history/history.h
@@ -552,8 +552,12 @@ class HistoryService : public CancelableRequestProvider,
//
// Calling this function many times may be slow because each call will
// dispatch to the history thread and will be a separate database
- // transaction. If this functionality is needed for importing many URLs, a
- // version that takes an array should probably be added.
+ // transaction. If this functionality is needed for importing many URLs,
+ // callers should use AddPagesWithDetails() instead.
+ //
+ // Note that this routine (and AddPageWithDetails()) always adds a single
+ // visit using the |last_visit| timestamp, and a PageTransition type of LINK,
+ // if |visit_source| != SYNCED.
void AddPageWithDetails(const GURL& url,
const string16& title,
int visit_count,
« no previous file with comments | « no previous file | chrome/browser/history/history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698