Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Side by Side Diff: chrome/browser/history/history.h

Issue 7104088: Changed typed url sync to no longer modify typed/visit_count. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated per review comments. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/history/history_backend.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_H_
7 #pragma once 7 #pragma once
8 8
9 #include <set> 9 #include <set>
10 #include <vector> 10 #include <vector>
(...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 // There can be only one closing task, so this will override any previously 545 // There can be only one closing task, so this will override any previously
546 // set task. We will take ownership of the pointer and delete it when done. 546 // set task. We will take ownership of the pointer and delete it when done.
547 // The task will be run on the calling thread (this function is threadsafe). 547 // The task will be run on the calling thread (this function is threadsafe).
548 void SetOnBackendDestroyTask(Task* task); 548 void SetOnBackendDestroyTask(Task* task);
549 549
550 // Used for unit testing and potentially importing to get known information 550 // Used for unit testing and potentially importing to get known information
551 // into the database. This assumes the URL doesn't exist in the database 551 // into the database. This assumes the URL doesn't exist in the database
552 // 552 //
553 // Calling this function many times may be slow because each call will 553 // Calling this function many times may be slow because each call will
554 // dispatch to the history thread and will be a separate database 554 // dispatch to the history thread and will be a separate database
555 // transaction. If this functionality is needed for importing many URLs, a 555 // transaction. If this functionality is needed for importing many URLs,
556 // version that takes an array should probably be added. 556 // callers should use AddPagesWithDetails() instead.
557 //
558 // Note that this routine (and AddPageWithDetails()) always adds a single
559 // visit using the |last_visit| timestamp, and a PageTransition type of LINK,
560 // if |visit_source| != SYNCED.
557 void AddPageWithDetails(const GURL& url, 561 void AddPageWithDetails(const GURL& url,
558 const string16& title, 562 const string16& title,
559 int visit_count, 563 int visit_count,
560 int typed_count, 564 int typed_count,
561 base::Time last_visit, 565 base::Time last_visit,
562 bool hidden, 566 bool hidden,
563 history::VisitSource visit_source); 567 history::VisitSource visit_source);
564 568
565 // The same as AddPageWithDetails() but takes a vector. 569 // The same as AddPageWithDetails() but takes a vector.
566 void AddPagesWithDetails(const std::vector<history::URLRow>& info, 570 void AddPagesWithDetails(const std::vector<history::URLRow>& info,
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
869 BookmarkService* bookmark_service_; 873 BookmarkService* bookmark_service_;
870 bool no_db_; 874 bool no_db_;
871 875
872 // True if needs top site migration. 876 // True if needs top site migration.
873 bool needs_top_sites_migration_; 877 bool needs_top_sites_migration_;
874 878
875 DISALLOW_COPY_AND_ASSIGN(HistoryService); 879 DISALLOW_COPY_AND_ASSIGN(HistoryService);
876 }; 880 };
877 881
878 #endif // CHROME_BROWSER_HISTORY_HISTORY_H_ 882 #endif // CHROME_BROWSER_HISTORY_HISTORY_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/history/history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698