ui/views: Fix the signature of View::OnViewAdded/Removed overridden methods.

ui/views: Fix the signature of View::OnViewAdded/Removed overridden methods.

The signature changed from (commit bf2f7326):
virtual void OnViewAdded(View* parent, View* child);

To:
virtual void OnViewAdded(const View& parent, const View& child);

BUG=72040
TEST=None

R=ben@chromium.org,sky@chromium.org,pkasting@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88392

[tfarina, 2011-06-07 23:34:35]

Please, take a look.

[sky, 2011-06-08 15:57:35]

I'm not seeing these methods anymore.

  -Scott

http://codereview.chromium.org/7104042/diff/1004/ui/views/view_unittest.cc
File ui/views/view_unittest.cc (right):

http://codereview.chromium.org/7104042/diff/1004/ui/views/view_unittest.cc#ne...
ui/views/view_unittest.cc:60: ObserverView() : view_added_(false),
The old code is the correct indentation style. See
http://www.corp.google.com/eng/doc/cppguide.xml#Constructor_Initializer_Lists .

[tfarina, 2011-06-08 17:30:00]

On Wed, Jun 8, 2011 at 12:57 PM,  <sky@chromium.org> wrote:
> I'm not seeing these methods anymore.
>
See:

http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/ui/views/view.h&exact...


-- 
Thiago

[sky, 2011-06-08 17:36:34]

My mistake, I was looking in views not ui/views. You need to ask Ben about this
before doing the change. I have a feeling ui/views is going to be nuked soon.

  -Scott

[tfarina, 2011-06-08 18:05:03]

On 2011/06/08 17:36:34, sky wrote:
> My mistake, I was looking in views not ui/views. You need to ask Ben about
this
> before doing the change. I have a feeling ui/views is going to be nuked soon.
>
Added Ben for review. Ben, please, could you take a look? ^^

[Peter Kasting, 2011-06-08 19:10:53]

No harm in fixing these, I did similar things myself a while ago.

LGTM with sky's nit fixed.

[tfarina, 2011-06-08 19:13:56]

http://codereview.chromium.org/7104042/diff/1004/ui/views/view_unittest.cc
File ui/views/view_unittest.cc (right):

http://codereview.chromium.org/7104042/diff/1004/ui/views/view_unittest.cc#ne...
ui/views/view_unittest.cc:60: ObserverView() : view_added_(false),
On 2011/06/08 15:57:35, sky wrote:
> The old code is the correct indentation style. See
> http://www.corp.google.com/eng/doc/cppguide.xml#Constructor_Initializer_Lists
.

Done.