ui/views: Fix the signature of View::OnViewAdded/Removed overridden methods.

ui/views/view_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
+#include "base/compiler_specific.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/canvas.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 
 namespace ui {
 
 class ViewTest : public testing::Test {
  public:
   ViewTest() {}
@@ skipping 32 matching lines @@
   v.RemoveChildView(&child2, false);
   EXPECT_EQ(1, v.children_size());
   EXPECT_EQ(NULL, child2.parent());
 
   //v.RemoveAllChildViews(false);
   //EXPECT_TRUE(v.children_empty());
 }
 
 class ObserverView : public View {
  public:
-  ObserverView()
-      : view_added_(false),
-        view_removed_(false),
-        subject_view_(NULL) {}
+  ObserverView() : view_added_(false),

[sky, 2011/06/08 15:57:35]

The old code is the correct indentation style. See
http://www.corp.google.com/eng/doc/cppguide.xml#Constructor_Initializer_Lists .

[tfarina, 2011/06/08 19:13:56]

Done.

+                   view_removed_(false),
+                   subject_view_(NULL) {}
   virtual ~ObserverView() {}
 
   void ResetTestState() {
     view_added_ = false;
     view_removed_ = false;
     subject_view_ = NULL;
   }
 
   // Overridden from View:
-  virtual void OnViewAdded(View* parent, View* child) {
-    subject_view_ = child;
+  virtual void OnViewAdded(const View& parent, const View& child) OVERRIDE {
     view_added_ = true;
     view_removed_ = false;
+    subject_view_ = &child;
   }
-  virtual void OnViewRemoved(View* parent, View* child) {
-    subject_view_ = child;
+  virtual void OnViewRemoved(const View& parent, const View& child) OVERRIDE {
+    view_added_ = false;
     view_removed_ = true;
-    view_added_ = false;
+    subject_view_ = &child;
   }
 
   bool view_added() const { return view_added_; }
   bool view_removed() const { return view_removed_; }
   View* subject_view() const { return subject_view_; }
 
  private:
   bool view_added_;
   bool view_removed_;
   View* subject_view_;
@@ skipping 104 matching lines @@
 
 TEST_F(ViewTest, EventHandlers) {
 
 }
 
 TEST_F(ViewTest, Painting) {
 
 }
 
 }  // namespace ui