Issue 7104007: Make sure paths that look like http://git_server/repo.git@SHA get checked out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7104007: Make sure paths that look like http://git_server/repo.git@SHA get checked out (Closed)

Created:
9 years, 6 months ago by Nicolas Sylvain

Modified:
9 years, 6 months ago

Reviewers:
cmp, Mandeep Singh Baines, nsylvain, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Make sure paths that look like http://git_server/repo.git@SHA get checked out correctly. The current behavior was to call git clone with --no-checkout, which did not create a working copy, and made the checkout unusable by the users. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87491

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	gclient_scm.py	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cmp

9 years, 6 months ago (2011-05-31 22:22:08 UTC) #3

lgtm

http://codereview.chromium.org/7104007/diff/1/gclient_scm.py
File gclient_scm.py (left):

http://codereview.chromium.org/7104007/diff/1/gclient_scm.py#oldcode491
gclient_scm.py:491: clone_cmd.append('--no-checkout')
This would have made a working copy with no usable files in it, since only a
.git directory would be present only the history/logs would be available to
other git commands and no actual files in the checkout would be available for
use.  I verified by running a clone -n of manifest.git.

Removing the flag is correct since we need to use those checkouts now.

Expand Messages | Collapse Messages