Make sure paths that look like http://git_server/repo.git@SHA get checked out

gclient_scm.py

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Gclient-specific SCM-specific operations."""
 
 import logging
 import os
 import posixpath
 import re
@@ skipping 470 matching lines @@
     if not options.verbose:
       # git clone doesn't seem to insert a newline properly before printing
       # to stdout
       print('')
 
     clone_cmd = ['clone']
     if revision.startswith('refs/heads/'):
       clone_cmd.extend(['-b', revision.replace('refs/heads/', '')])
       detach_head = False
     else:
-      clone_cmd.append('--no-checkout')

[cmp, 2011/05/31 22:22:08]

This would have made a working copy with no usable files in it, since only a
.git directory would be present only the history/logs would be available to
other git commands and no actual files in the checkout would be available for
use.  I verified by running a clone -n of manifest.git.

Removing the flag is correct since we need to use those checkouts now.

       detach_head = True
     if options.verbose:
       clone_cmd.append('--verbose')
     clone_cmd.extend([url, self.checkout_path])
 
     for _ in range(3):
       try:
         self._Run(clone_cmd, options, cwd=self._root_dir)
         break
       except (gclient_utils.Error, subprocess2.CalledProcessError), e:
@@ skipping 430 matching lines @@
 
     This method returns a new list to be used as a command."""
     new_command = command[:]
     if revision:
       new_command.extend(['--revision', str(revision).strip()])
     # --force was added to 'svn update' in svn 1.5.
     if ((options.force or options.manually_grab_svn_rev) and
         scm.SVN.AssertVersion("1.5")[0]):
       new_command.append('--force')
     return new_command