Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1249)

Unified Diff: chrome/browser/web_resource/web_resource_service.h

Issue 7099004: Use the System URL Request Context in the web resource service instead of the default profile's c... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/web_resource_service.h
===================================================================
--- chrome/browser/web_resource/web_resource_service.h (revision 88135)
+++ chrome/browser/web_resource/web_resource_service.h (working copy)
@@ -12,7 +12,6 @@
#include "content/common/notification_type.h"
class PrefService;
-class Profile;
class ResourceDispatcherHost;
// A WebResourceService fetches data from a web resource server and store
@@ -22,8 +21,7 @@
public:
// Pass notification_type = NOTIFICATION_TYPE_COUNT if notification is not
// required.
- WebResourceService(Profile* profile,
- PrefService* prefs,
+ WebResourceService(PrefService* prefs,
const char* web_resource_server,
bool apply_locale_to_url_,
NotificationType::Type notification_type,
@@ -53,8 +51,6 @@
// and get proper install directory.
PrefService* prefs_;
- Profile* profile_;
-
private:
class WebResourceFetcher;
friend class WebResourceFetcher;
@@ -84,7 +80,9 @@
// kCacheUpdateDelay time, and silently exit.
bool in_fetch_;
- // URL that hosts the web resource.
+ // URL that hosts the web resource. This URL will be loaded with a
+ // SystemURLRequestContext, so should not depend on Profile request context
+ // data (see http://codereview.chromium.org/7099004/).
const char* web_resource_server_;
// Indicates whether we should append locale to the web resource server URL.
« no previous file with comments | « chrome/browser/web_resource/promo_resource_service.cc ('k') | chrome/browser/web_resource/web_resource_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698