chrome/browser/sidebar/sidebar_container.h - Issue 7096016: Remove JS dialog dependency from content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sidebar/sidebar_container.h

Issue 7096016: Remove JS dialog dependency from content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: now a tc delegate Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sidebar/sidebar_container.h

diff --git a/chrome/browser/sidebar/sidebar_container.h b/chrome/browser/sidebar/sidebar_container.h

index 0fe1cb3663b48ff7521688504039cb136e729e26..f041853ffc94da5886dd88be2f24fa98ca910e94 100644

--- a/chrome/browser/sidebar/sidebar_container.h

+++ b/chrome/browser/sidebar/sidebar_container.h

@@ -113,6 +113,8 @@ class SidebarContainer

virtual void MoveContents(TabContents* source, const gfx::Rect& pos) {}

virtual bool IsPopup(const TabContents* source) const;

virtual void UpdateTargetURL(TabContents* source, const GURL& url) {}

+ virtual content::JavaScriptDialogCreator* GetJavaScriptDialogCreator(

+ ) OVERRIDE;

// Overridden from ImageLoadingTracker::Observer.

virtual void OnImageLoaded(SkBitmap* image,