Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: chrome/browser/sidebar/sidebar_container.h

Issue 7096016: Remove JS dialog dependency from content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: now a tc delegate Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_ 5 #ifndef CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_
6 #define CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_ 6 #define CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 WindowOpenDisposition disposition, 106 WindowOpenDisposition disposition,
107 const gfx::Rect& initial_pos, 107 const gfx::Rect& initial_pos,
108 bool user_gesture) {} 108 bool user_gesture) {}
109 virtual void ActivateContents(TabContents* contents) {} 109 virtual void ActivateContents(TabContents* contents) {}
110 virtual void DeactivateContents(TabContents* contents) {} 110 virtual void DeactivateContents(TabContents* contents) {}
111 virtual void LoadingStateChanged(TabContents* source) {} 111 virtual void LoadingStateChanged(TabContents* source) {}
112 virtual void CloseContents(TabContents* source) {} 112 virtual void CloseContents(TabContents* source) {}
113 virtual void MoveContents(TabContents* source, const gfx::Rect& pos) {} 113 virtual void MoveContents(TabContents* source, const gfx::Rect& pos) {}
114 virtual bool IsPopup(const TabContents* source) const; 114 virtual bool IsPopup(const TabContents* source) const;
115 virtual void UpdateTargetURL(TabContents* source, const GURL& url) {} 115 virtual void UpdateTargetURL(TabContents* source, const GURL& url) {}
116 virtual content::JavaScriptDialogCreator* GetJavaScriptDialogCreator(
117 ) OVERRIDE;
116 118
117 // Overridden from ImageLoadingTracker::Observer. 119 // Overridden from ImageLoadingTracker::Observer.
118 virtual void OnImageLoaded(SkBitmap* image, 120 virtual void OnImageLoaded(SkBitmap* image,
119 const ExtensionResource& resource, 121 const ExtensionResource& resource,
120 int index); 122 int index);
121 123
122 // Returns an extension this sidebar belongs to. 124 // Returns an extension this sidebar belongs to.
123 const Extension* GetExtension() const; 125 const Extension* GetExtension() const;
124 126
125 // Contents of the tab this sidebar is linked to. 127 // Contents of the tab this sidebar is linked to.
(...skipping 29 matching lines...) Expand all
155 // icon should be used or discarded. 157 // icon should be used or discarded.
156 bool use_default_icon_; 158 bool use_default_icon_;
157 159
158 // Helper to load icons from extension asynchronously. 160 // Helper to load icons from extension asynchronously.
159 scoped_ptr<ImageLoadingTracker> image_loading_tracker_; 161 scoped_ptr<ImageLoadingTracker> image_loading_tracker_;
160 162
161 DISALLOW_COPY_AND_ASSIGN(SidebarContainer); 163 DISALLOW_COPY_AND_ASSIGN(SidebarContainer);
162 }; 164 };
163 165
164 #endif // CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_ 166 #endif // CHROME_BROWSER_SIDEBAR_SIDEBAR_CONTAINER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698