Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5010)

Unified Diff: chrome/browser/external_tab_container_win.h

Issue 7096016: Remove JS dialog dependency from content. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: now a tc delegate Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/external_tab_container_win.h
diff --git a/chrome/browser/external_tab_container_win.h b/chrome/browser/external_tab_container_win.h
index e5435771f1c57d1cacee50f42baa1d877a9eab19..ba0fd6e86a8237afa1017802f20f459f9175166a 100644
--- a/chrome/browser/external_tab_container_win.h
+++ b/chrome/browser/external_tab_container_win.h
@@ -170,6 +170,9 @@ class ExternalTabContainer : public TabContentsDelegate,
void RegisterRenderViewHost(RenderViewHost* render_view_host);
void UnregisterRenderViewHost(RenderViewHost* render_view_host);
+ virtual content::JavaScriptDialogCreator* GetJavaScriptDialogCreator(
jam 2011/06/03 00:21:45 this should be with the other TabContentsDelegate
+ ) OVERRIDE;
jam 2011/06/03 00:21:45 nit: this seems awkward to read. do you think it'
+
// Overridden from TabContentsObserver:
// IPC::Channel::Listener implementation.
virtual bool OnMessageReceived(const IPC::Message& message);

Powered by Google App Engine
This is Rietveld 408576698