Remove JS dialog dependency from content.

chrome/browser/external_tab_container_win.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_
 #define CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 152 matching lines @@
 
   virtual void BeforeUnloadFired(TabContents* tab,
                                  bool proceed,
                                  bool* proceed_to_fire_unload);
 
   void ShowRepostFormWarningDialog(TabContents* tab_contents);
 
   void RegisterRenderViewHost(RenderViewHost* render_view_host);
   void UnregisterRenderViewHost(RenderViewHost* render_view_host);
 
+  virtual content::JavaScriptDialogCreator* GetJavaScriptDialogCreator(

[jam, 2011/06/03 00:21:45]

this should be with the other TabContentsDelegate methods right?  (i.e. at 169,
and looks like ShowRepostFormWarningDialog is missing a virtual)

+      ) OVERRIDE;

[jam, 2011/06/03 00:21:45]

nit: this seems awkward to read.  do you think it'd be more readable if the
function name was on the following line?

+
   // Overridden from TabContentsObserver:
   // IPC::Channel::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& message);
 
   // Message handlers
   void OnForwardMessageToExternalHost(const std::string& message,
                                       const std::string& origin,
                                       const std::string& target);
 
   // Overridden from NotificationObserver:
@@ skipping 226 matching lines @@
     return false;
   }
 
   virtual void BeforeUnloadFired(TabContents* tab, bool proceed,
                                  bool* proceed_to_fire_unload) {
     NOTREACHED();
   }
 };
 
 #endif  // CHROME_BROWSER_EXTERNAL_TAB_CONTAINER_WIN_H_