Issue 7096006: Update apply with arguments optimization for strict mode functions and builtins.

Issue 7096006: Update apply with arguments optimization for strict mode functions and builtins. (Closed)

Created:
9 years, 6 months ago by Mads Ager (chromium)

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Update apply with arguments optimization for strict mode functions and builtins. Do not convert to object for values for strict-mode functions and builtins. R=ricow@chromium.org BUG=v8:1412 TEST=mjsunit/regress/regress-1412.js

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -55 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+19 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+18 lines, -5 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+20 lines, -5 lines	0 comments	Download
D	test/mjsunit/bugs/bug-1412.js	View		1 chunk	+0 lines, -34 lines	0 comments	Download
A +	test/mjsunit/regress/regress-1412.js	View	1	1 chunk	+30 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/7096006/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/7096006/diff/1/src/x64/lithium-codegen-x64.cc#newcode2629 src/x64/lithium-codegen-x64.cc:2629: __ j(not_zero, &receiver_ok, Label::kNear); __ j(not_equal to be ...

9 years, 6 months ago (2011-05-31 10:31:15 UTC) #2

Mads Ager (chromium)

9 years, 6 months ago (2011-05-31 10:33:22 UTC) #3

Thanks Rico.

http://codereview.chromium.org/7096006/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/7096006/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2629: __ j(not_zero, &receiver_ok, Label::kNear);
On 2011/05/31 10:31:15, Rico wrote:
> __ j(not_equal to be consistent (I wonder who originally started with this
> inconsistent mess in the x64 builtins file :-))

Done. Also in builtins-x64.cc.

http://codereview.chromium.org/7096006/diff/1/test/mjsunit/regress/regress-14...
File test/mjsunit/regress/regress-1412.js (right):

http://codereview.chromium.org/7096006/diff/1/test/mjsunit/regress/regress-14...
test/mjsunit/regress/regress-1412.js:29: // unchanged to strict mode functions.
On 2011/05/31 10:31:15, Rico wrote:
> unchanged to strict mode functions -> unchanged to strict mode functions and
> builtins

Done.

Expand Messages | Collapse Messages