src/x64/builtins-x64.cc - Issue 7096006: Update apply with arguments optimization for strict mode functions and builtins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/builtins-x64.cc

Issue 7096006: Update apply with arguments optimization for strict mode functions and builtins. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/builtins-x64.cc

diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc

index 62f2b57a7de121d182a1512ec3f4bb211e789351..064ea77e9cfd8ca31b7e4806a4085d6151753736 100644

--- a/src/x64/builtins-x64.cc

+++ b/src/x64/builtins-x64.cc

@@ -849,7 +849,7 @@ void Builtins::Generate_FunctionApply(MacroAssembler* masm) {

// Do not transform the receiver for natives.

__ testb(FieldOperand(rdx, SharedFunctionInfo::kNativeByteOffset),

Immediate(1 << SharedFunctionInfo::kNativeBitWithinByte));

- __ j(not_zero, &push_receiver);

+ __ j(not_equal, &push_receiver);

// Compute the receiver in non-strict mode.

__ JumpIfSmi(rbx, &call_to_object, Label::kNear);

« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »