Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler.h

Issue 7093004: Sync: Refactor the ProfileSyncService and sync setup flow to remove use of WebUI from PSS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add tests, fixes. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/sync_setup_handler.h
diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.h b/chrome/browser/ui/webui/options/sync_setup_handler.h
index 1159e1d6a356ee33e8d55bf0db75c90d5427bcbd..6479f4718f28a8677872443a10befefaee6dfda2 100644
--- a/chrome/browser/ui/webui/options/sync_setup_handler.h
+++ b/chrome/browser/ui/webui/options/sync_setup_handler.h
@@ -32,15 +32,31 @@ class SyncSetupHandler : public OptionsPageUIHandler,
virtual void SetFlow(SyncSetupFlow* flow);
- private:
- // Callbacks from the page.
+ protected:
+ FRIEND_TEST_ALL_PREFIXES(SyncSetupWizardTest, InitialStepLogin);
+ FRIEND_TEST_ALL_PREFIXES(SyncSetupWizardTest, ChooseDataTypesSetsPrefs);
+ FRIEND_TEST_ALL_PREFIXES(SyncSetupWizardTest, DialogCancelled);
+ FRIEND_TEST_ALL_PREFIXES(SyncSetupWizardTest, InvalidTransitions);
+ FRIEND_TEST_ALL_PREFIXES(SyncSetupWizardTest, FullSuccessfulRunSetsPref);
+ FRIEND_TEST_ALL_PREFIXES(SyncSetupWizardTest, AbortedByPendingClear);
+ FRIEND_TEST_ALL_PREFIXES(SyncSetupWizardTest, DiscreteRunGaiaLogin);
+ FRIEND_TEST_ALL_PREFIXES(SyncSetupWizardTest, DiscreteRunChooseDataTypes);
+ FRIEND_TEST_ALL_PREFIXES(SyncSetupWizardTest,
+ DiscreteRunChooseDataTypesAbortedByPendingClear);
+ FRIEND_TEST_ALL_PREFIXES(SyncSetupWizardTest, EnterPassphraseRequired);
+
+ // Callbacks from the page. Protected in order to be called by the
binji 2011/06/13 22:32:52 finish comment
James Hawkins 2011/06/13 23:14:52 Done.
void OnDidClosePage(const ListValue* args);
void HandleSubmitAuth(const ListValue* args);
void HandleConfigure(const ListValue* args);
void HandlePassphraseEntry(const ListValue* args);
void HandlePassphraseCancel(const ListValue* args);
void HandleAttachHandler(const ListValue* args);
+ void HandleShowErrorUI(const ListValue* args);
+ SyncSetupFlow* flow() { return flow_; }
+
+ private:
// Weak reference.
SyncSetupFlow* flow_;

Powered by Google App Engine
This is Rietveld 408576698