Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1970)

Unified Diff: chrome/browser/ui/webui/options/personal_options_handler.cc

Issue 7093004: Sync: Refactor the ProfileSyncService and sync setup flow to remove use of WebUI from PSS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add tests, fixes. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/personal_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/personal_options_handler.cc b/chrome/browser/ui/webui/options/personal_options_handler.cc
index e3ed25bc029bc551a21f4f9b0c363698865c39bd..0ca151d8633aa0c15fabb22603efc2a720bf0c27 100644
--- a/chrome/browser/ui/webui/options/personal_options_handler.cc
+++ b/chrome/browser/ui/webui/options/personal_options_handler.cc
@@ -192,15 +192,6 @@ void PersonalOptionsHandler::GetLocalizedValues(
void PersonalOptionsHandler::RegisterMessages() {
DCHECK(web_ui_);
web_ui_->RegisterMessageCallback(
- "showSyncActionDialog",
- NewCallback(this, &PersonalOptionsHandler::ShowSyncActionDialog));
- web_ui_->RegisterMessageCallback(
- "showSyncLoginDialog",
- NewCallback(this, &PersonalOptionsHandler::ShowSyncLoginDialog));
- web_ui_->RegisterMessageCallback(
- "showCustomizeSyncDialog",
- NewCallback(this, &PersonalOptionsHandler::ShowCustomizeSyncDialog));
- web_ui_->RegisterMessageCallback(
"themesReset",
NewCallback(this, &PersonalOptionsHandler::ThemesReset));
#if defined(TOOLKIT_GTK)
@@ -386,25 +377,6 @@ void PersonalOptionsHandler::Initialize() {
}
}
-void PersonalOptionsHandler::ShowSyncActionDialog(const ListValue* args) {
- ProfileSyncService* service = web_ui_->GetProfile()->GetProfileSyncService();
- DCHECK(service);
- service->ShowErrorUI(web_ui_);
-}
-
-void PersonalOptionsHandler::ShowSyncLoginDialog(const ListValue* args) {
- ProfileSyncService* service = web_ui_->GetProfile()->GetProfileSyncService();
- DCHECK(service);
- service->ShowLoginDialog(web_ui_);
- ProfileSyncService::SyncEvent(ProfileSyncService::START_FROM_OPTIONS);
-}
-
-void PersonalOptionsHandler::ShowCustomizeSyncDialog(const ListValue* args) {
- ProfileSyncService* service = web_ui_->GetProfile()->GetProfileSyncService();
- DCHECK(service);
- service->ShowConfigure(web_ui_, false);
-}
-
void PersonalOptionsHandler::ThemesReset(const ListValue* args) {
UserMetricsRecordAction(UserMetricsAction("Options_ThemesReset"));
ThemeServiceFactory::GetForProfile(web_ui_->GetProfile())->UseDefaultTheme();

Powered by Google App Engine
This is Rietveld 408576698