chrome/browser/geolocation/geolocation_content_settings_map.cc - Issue 7088017: Split incognito extension content settings in session-only and persistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_content_settings_map.cc

Issue 7088017: Split incognito extension content settings in session-only and persistent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_content_settings_map.cc

diff --git a/chrome/browser/geolocation/geolocation_content_settings_map.cc b/chrome/browser/geolocation/geolocation_content_settings_map.cc

index daee1bd8d97a9605bd75b0250e5d7e4e3979824a..443ecc83dd36faa3ee80dd03e0510d3a1789d91c 100644

--- a/chrome/browser/geolocation/geolocation_content_settings_map.cc

+++ b/chrome/browser/geolocation/geolocation_content_settings_map.cc

@@ -211,10 +211,10 @@ void GeolocationContentSettingsMap::Observe(

if (type == NotificationType::PREF_CHANGED) {

const std::string& name = *Details<std::string>(details).ptr();

if (name == prefs::kGeolocationDefaultContentSetting) {

- NotifyObservers(ContentSettingsDetails(

- ContentSettingsPattern(),

- CONTENT_SETTINGS_TYPE_DEFAULT,

- ""));

+ ContentSettingsDetails details(ContentSettingsPattern(),

+ CONTENT_SETTINGS_TYPE_DEFAULT,

+ std::string());

+ NotifyObservers(details);

}

} else if (NotificationType::PROFILE_DESTROYED == type) {

UnregisterObservers();