Split incognito extension content settings in session-only and persistent.

chrome/browser/geolocation/geolocation_content_settings_map.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of the geolocation content settings map. Styled on
 // HostContentSettingsMap however unlike that class, this one does not hold
 // an additional in-memory copy of the settings as it does not need to support
 // thread safe synchronous access to the settings; all geolocation permissions
 // are read and written in the UI thread. (If in future this is no longer the
 // case, refer to http://codereview.chromium.org/1525018 for a previous version
@@ skipping 193 matching lines @@
       Details<const ContentSettingsDetails>(&details));
 }
 
 void GeolocationContentSettingsMap::Observe(
     NotificationType type,
     const NotificationSource& source,
     const NotificationDetails& details) {
   if (type == NotificationType::PREF_CHANGED) {
     const std::string& name = *Details<std::string>(details).ptr();
     if (name == prefs::kGeolocationDefaultContentSetting) {
-      NotifyObservers(ContentSettingsDetails(
-      ContentSettingsPattern(),
-      CONTENT_SETTINGS_TYPE_DEFAULT,
-      ""));
+      ContentSettingsDetails details(ContentSettingsPattern(),
+                                     CONTENT_SETTINGS_TYPE_DEFAULT,
+                                     std::string());
+      NotifyObservers(details);
     }
   } else if (NotificationType::PROFILE_DESTROYED == type) {
     UnregisterObservers();
   } else {
     NOTREACHED();
   }
 }
 
 void GeolocationContentSettingsMap::UnregisterObservers() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ skipping 20 matching lines @@
     bool found = dictionary->GetIntegerWithoutPathExpansion(target, &setting);
     DCHECK(found);
     GURL target_url(target);
     // An empty URL has a special meaning (wildcard), so only accept invalid
     // URLs if the original version was empty (avoids treating corrupted prefs
     // as the wildcard entry; see http://crbug.com/39685)
     if (target_url.is_valid() || target.empty())
       (*one_origin_settings)[target_url] = IntToContentSetting(setting);
   }
 }