Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 7087030: Upgrade all multi-install products present on the system when the installer is run with only the ... (Closed)

Created:
9 years, 6 months ago by grt (UTC plus 2)
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Upgrade all multi-install products present on the system when the installer is run with only the --multi-install switch. This will allow us to greatly simplify the Google Update server config for the Chrome binaries app id, as it will no longer need to call out every permutation of product installations. BUG=76695 TEST=On a system with one or more multi-install products installed, run the installer with --multi-install [ --system-level ] [ --verbose-logging ] and notice that all multi-install products are updated. Run it on a system with no multi-install products and notice that it returns 15 (CHROME_NOT_INSTALLED) and puts the proper error info into the Chrome binaries' ClientState key. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87314

Patch Set 1 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 5 chunks +15 lines, -7 lines 1 comment Download
M chrome/installer/util/prebuild/create_string_rc.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
grt (UTC plus 2)
9 years, 6 months ago (2011-05-30 18:06:12 UTC) #1
robertshield
LGTM http://codereview.chromium.org/7087030/diff/10/chrome/installer/setup/setup_main.cc File chrome/installer/setup/setup_main.cc (right): http://codereview.chromium.org/7087030/diff/10/chrome/installer/setup/setup_main.cc#newcode371 chrome/installer/setup/setup_main.cc:371: AddExistingMultiInstalls(original_state, installer_state); Nice fix :)
9 years, 6 months ago (2011-05-31 15:30:19 UTC) #2
grt (UTC plus 2)
On 2011/05/31 15:30:19, robertshield wrote: > LGTM > > http://codereview.chromium.org/7087030/diff/10/chrome/installer/setup/setup_main.cc > File chrome/installer/setup/setup_main.cc (right): > ...
9 years, 6 months ago (2011-05-31 15:33:13 UTC) #3
commit-bot: I haz the power
9 years, 6 months ago (2011-05-31 16:32:18 UTC) #4
Change committed as 87314

Powered by Google App Engine
This is Rietveld 408576698