Issue 7086030: Refresh the history page if history entries get deleted, except for when currently editing entries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7086030: Refresh the history page if history entries get deleted, except for when currently editing entries (Closed)

Created:
9 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, arv (Not doing code reviews), tburkard

CC:
chromium-reviews, joi+watch-content_chromium.org, arv (Not doing code reviews), jam, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Refresh the history page if history entries get deleted, except for when currently editing entries BUG=82190 TEST=manual as described in the bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88525

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : rebase #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -4 lines)			Patch
M	chrome/browser/resources/history.js	View	1	3 chunks	+19 lines, -1 line	0 comments	Download
M	chrome/browser/resources/history2.html	View	1	3 chunks	+19 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/history2_ui.h	View	1 2	4 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/history2_ui.cc	View	1 2	3 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/history_ui.h	View	1 2	3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/history_ui.cc	View	1 2	3 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Can't apply patch for file chrome/browser/ui/webui/history_ui.h. While running patch -p1 --forward --force; patching file chrome/browser/ui/webui/history_ui.h ...

9 years, 6 months ago (2011-06-09 12:49:54 UTC) #3

Change committed as 88525

Expand Messages | Collapse Messages