Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chrome/browser/resources/history.js

Issue 7086030: Refresh the history page if history entries get deleted, except for when currently editing entries (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/history2.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/history.js
diff --git a/chrome/browser/resources/history.js b/chrome/browser/resources/history.js
index c0a5287d0a4e25675b0b1cfd959a70ceeccc5073..3fbb3007e2cb6b06ce52537e36cddf59dcf3b76e 100644
--- a/chrome/browser/resources/history.js
+++ b/chrome/browser/resources/history.js
@@ -512,6 +512,14 @@ HistoryView.prototype.toggleEditMode = function() {
};
/**
+ * @return {boolean} Whether we are in edit mode where history items can be
+ * deleted
+ */
+HistoryView.prototype.getEditMode = function() {
+ return this.model_.getEditMode();
+};
+
+/**
* Reload the current view.
*/
HistoryView.prototype.reload = function() {
@@ -1022,7 +1030,6 @@ function deleteComplete() {
deleteNextInQueue();
} else {
deleteQueue = [];
- historyView.reload();
}
}
@@ -1037,6 +1044,17 @@ function deleteFailed() {
setTimeout(deleteNextInQueue, 500);
}
+/**
+ * We're called when something is deleted (either by us or by someone
+ * else).
+ */
+function historyDeleted() {
+ window.console.log('History deleted');
+ var anyChecked = document.querySelector('.entry input:checked') != null;
+ if (!(historyView.getEditMode() && anyChecked))
+ historyView.reload();
+}
+
// Add handlers to HTML elements.
document.body.onload = load;
$('history-section').onclick = function () {
« no previous file with comments | « no previous file | chrome/browser/resources/history2.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698