Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 7086029: Fix a number of IC stubs to correctly set the call kind. (Closed)

Created:
9 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 6 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix a number of IC stubs to correctly set the call kind. Make the call kind and call wrapper arguments explicit to force developers to make a choice. This would have avoided the bug in the first case. R=fschneider@chromium.org TEST=mjsunit/strict-mode-implicit-receiver.js Committed: http://code.google.com/p/v8/source/detail?r=8109

Patch Set 1 #

Patch Set 2 : Load global object from rsi on x64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -142 lines) Patch
M src/arm/builtins-arm.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/ic-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +9 lines, -8 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 14 chunks +31 lines, -20 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +8 lines, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 13 chunks +42 lines, -18 lines 0 comments Download
M src/stub-cache.h View 1 chunk +19 lines, -14 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/x64/builtins-x64.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 4 chunks +9 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +8 lines, -7 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 11 chunks +41 lines, -17 lines 0 comments Download
A test/mjsunit/bugs/bug-1412.js View 1 chunk +34 lines, -0 lines 0 comments Download
M test/mjsunit/strict-mode-implicit-receiver.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 6 months ago (2011-05-30 12:08:02 UTC) #1
fschneider
9 years, 6 months ago (2011-05-30 13:04:56 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698