Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/macro-assembler-ia32.h

Issue 7086029: Fix a number of IC stubs to correctly set the call kind. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Load global object from rsi on x64. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 // Setup call kind marking in ecx. The method takes ecx as an 156 // Setup call kind marking in ecx. The method takes ecx as an
157 // explicit first parameter to make the code more readable at the 157 // explicit first parameter to make the code more readable at the
158 // call sites. 158 // call sites.
159 void SetCallKind(Register dst, CallKind kind); 159 void SetCallKind(Register dst, CallKind kind);
160 160
161 // Invoke the JavaScript function code by either calling or jumping. 161 // Invoke the JavaScript function code by either calling or jumping.
162 void InvokeCode(const Operand& code, 162 void InvokeCode(const Operand& code,
163 const ParameterCount& expected, 163 const ParameterCount& expected,
164 const ParameterCount& actual, 164 const ParameterCount& actual,
165 InvokeFlag flag, 165 InvokeFlag flag,
166 const CallWrapper& call_wrapper = NullCallWrapper(), 166 const CallWrapper& call_wrapper,
167 CallKind call_kind = CALL_AS_METHOD); 167 CallKind call_kind);
168 168
169 void InvokeCode(Handle<Code> code, 169 void InvokeCode(Handle<Code> code,
170 const ParameterCount& expected, 170 const ParameterCount& expected,
171 const ParameterCount& actual, 171 const ParameterCount& actual,
172 RelocInfo::Mode rmode, 172 RelocInfo::Mode rmode,
173 InvokeFlag flag, 173 InvokeFlag flag,
174 const CallWrapper& call_wrapper = NullCallWrapper(), 174 const CallWrapper& call_wrapper,
175 CallKind call_kind = CALL_AS_METHOD); 175 CallKind call_kind);
176 176
177 // Invoke the JavaScript function in the given register. Changes the 177 // Invoke the JavaScript function in the given register. Changes the
178 // current context to the context in the function before invoking. 178 // current context to the context in the function before invoking.
179 void InvokeFunction(Register function, 179 void InvokeFunction(Register function,
180 const ParameterCount& actual, 180 const ParameterCount& actual,
181 InvokeFlag flag, 181 InvokeFlag flag,
182 const CallWrapper& call_wrapper = NullCallWrapper(), 182 const CallWrapper& call_wrapper,
183 CallKind call_kind = CALL_AS_METHOD); 183 CallKind call_kind);
184 184
185 void InvokeFunction(JSFunction* function, 185 void InvokeFunction(JSFunction* function,
186 const ParameterCount& actual, 186 const ParameterCount& actual,
187 InvokeFlag flag, 187 InvokeFlag flag,
188 const CallWrapper& call_wrapper = NullCallWrapper()); 188 const CallWrapper& call_wrapper,
189 CallKind call_kind);
189 190
190 // Invoke specified builtin JavaScript function. Adds an entry to 191 // Invoke specified builtin JavaScript function. Adds an entry to
191 // the unresolved list if the name does not resolve. 192 // the unresolved list if the name does not resolve.
192 void InvokeBuiltin(Builtins::JavaScript id, 193 void InvokeBuiltin(Builtins::JavaScript id,
193 InvokeFlag flag, 194 InvokeFlag flag,
194 const CallWrapper& call_wrapper = NullCallWrapper()); 195 const CallWrapper& call_wrapper = NullCallWrapper());
195 196
196 // Store the function for the given builtin in the target register. 197 // Store the function for the given builtin in the target register.
197 void GetBuiltinFunction(Register target, Builtins::JavaScript id); 198 void GetBuiltinFunction(Register target, Builtins::JavaScript id);
198 199
(...skipping 567 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 } \ 767 } \
767 masm-> 768 masm->
768 #else 769 #else
769 #define ACCESS_MASM(masm) masm-> 770 #define ACCESS_MASM(masm) masm->
770 #endif 771 #endif
771 772
772 773
773 } } // namespace v8::internal 774 } } // namespace v8::internal
774 775
775 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_ 776 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698