Context menu for "Voice recognition options"

content/browser/speech/speech_input_manager.h

Index: content/browser/speech/speech_input_manager.h
diff --git a/content/browser/speech/speech_input_manager.h b/content/browser/speech/speech_input_manager.h
index 342f2c139d7dc97ddfca349211ca97841f4d74ea..9cbd7e7582ec1e2eb92a387788a22a03b4d2af37 100644
--- a/content/browser/speech/speech_input_manager.h
+++ b/content/browser/speech/speech_input_manager.h
@@ -64,6 +64,13 @@ class SpeechInputManager {
   virtual void StopRecording(int caller_id) = 0;
 
   virtual void CancelAllRequestsWithDelegate(Delegate* delegate) = 0;
+
+  void NotifyCensorResults(bool censor_speech_results) {

[Satish, 2011/07/19 08:22:39]

suggest renaming to set_censor_results(), this goes with the following comments
to make this into a simple setter

[gshires, 2011/07/19 22:56:31]

Done.

+      profanity_filter_ = censor_speech_results ? 2 : 0; }

[Satish, 2011/07/19 08:22:39]

indent to left by 2 spaces and move closing brace to the next line.

[gshires, 2011/07/19 22:56:31]

Shortened to a single line

+
+  int ProfanityFilter() { return profanity_filter_; }

[Satish, 2011/07/19 08:22:39]

getters have the same name as the member variable they return without the
trailing underscore, i.e. "profanity_filter()" or "censor_results()" per the
next suggestion 

[gshires, 2011/07/19 22:56:31]

Done.

+ private:
+  int profanity_filter_;

[Satish, 2011/07/19 08:22:39]

It may be preferable to have this as a boolean (e.g. 'censor_results_') as
opposed to a value which makes sense to the speech service (0 and 2). In
speech_recognition_request.cc where the request is sent over the wire you can
select the appropriate value based on the boolean.

[gshires, 2011/07/19 22:56:31]

Done.

 };
 
 // This typedef is to workaround the issue with certain versions of