Context menu for "Voice recognition options"

content/browser/speech/speech_input_manager.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SPEECH_SPEECH_INPUT_MANAGER_H_
 #define CONTENT_BROWSER_SPEECH_SPEECH_INPUT_MANAGER_H_
 
 #include "base/basictypes.h"
 #include "content/common/speech_input_result.h"
 #include "ui/gfx/rect.h"
@@ skipping 46 matching lines @@
                                 int render_process_id,
                                 int render_view_id,
                                 const gfx::Rect& element_rect,
                                 const std::string& language,
                                 const std::string& grammar,
                                 const std::string& origin_url)  = 0;
   virtual void CancelRecognition(int caller_id) = 0;
   virtual void StopRecording(int caller_id) = 0;
 
   virtual void CancelAllRequestsWithDelegate(Delegate* delegate) = 0;
+
+  void NotifyCensorResults(bool censor_speech_results) {

[Satish, 2011/07/19 08:22:39]

suggest renaming to set_censor_results(), this goes with the following comments
to make this into a simple setter

[gshires, 2011/07/19 22:56:31]

Done.

+      profanity_filter_ = censor_speech_results ? 2 : 0; }

[Satish, 2011/07/19 08:22:39]

indent to left by 2 spaces and move closing brace to the next line.

[gshires, 2011/07/19 22:56:31]

Shortened to a single line

+
+  int ProfanityFilter() { return profanity_filter_; }

[Satish, 2011/07/19 08:22:39]

getters have the same name as the member variable they return without the
trailing underscore, i.e. "profanity_filter()" or "censor_results()" per the
next suggestion 

[gshires, 2011/07/19 22:56:31]

Done.

+ private:
+  int profanity_filter_;

[Satish, 2011/07/19 08:22:39]

It may be preferable to have this as a boolean (e.g. 'censor_results_') as
opposed to a value which makes sense to the speech service (0 and 2). In
speech_recognition_request.cc where the request is sent over the wire you can
select the appropriate value based on the boolean.

[gshires, 2011/07/19 22:56:31]

Done.

 };
 
 // This typedef is to workaround the issue with certain versions of
 // Visual Studio where it gets confused between multiple Delegate
 // classes and gives a C2500 error. (I saw this error on the try bots -
 // the workaround was not needed for my machine).
 typedef SpeechInputManager::Delegate SpeechInputManagerDelegate;
 
 }  // namespace speech_input
 
 #endif  // CONTENT_BROWSER_SPEECH_SPEECH_INPUT_MANAGER_H_