Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 7084010: Move sandbox_policy to content. (Closed)

Created:
9 years, 7 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move sandbox_policy to content. BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87183

Patch Set 1 : '' #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -654 lines) Patch
M chrome/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 5 chunks +0 lines, -113 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 4 chunks +112 lines, -0 lines 0 comments Download
D chrome/common/sandbox_policy.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/common/sandbox_policy.cc View 1 chunk +0 lines, -470 lines 0 comments Download
M chrome/nacl/broker_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/out_of_proc_test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/content_browser_client.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/content_browser_client.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/common/content_client.h View 1 3 chunks +11 lines, -0 lines 0 comments Download
M content/common/content_client.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
A + content/common/sandbox_policy.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/sandbox_policy.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_common.gypi View 2 chunks +7 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
jam
9 years, 7 months ago (2011-05-27 22:03:54 UTC) #1
Avi (use Gerrit)
Nits only. LGTM http://codereview.chromium.org/7084010/diff/6003/content/content_common.gypi File content/content_common.gypi (right): http://codereview.chromium.org/7084010/diff/6003/content/content_common.gypi#newcode264 content/content_common.gypi:264: }, { # OS!="win quote on ...
9 years, 7 months ago (2011-05-28 04:48:45 UTC) #2
jam
http://codereview.chromium.org/7084010/diff/6003/content/content_common.gypi File content/content_common.gypi (right): http://codereview.chromium.org/7084010/diff/6003/content/content_common.gypi#newcode264 content/content_common.gypi:264: }, { # OS!="win On 2011/05/28 04:48:45, Avi wrote: ...
9 years, 7 months ago (2011-05-28 18:48:30 UTC) #3
Avi (use Gerrit)
9 years, 7 months ago (2011-05-29 08:19:00 UTC) #4
SLGTM

Powered by Google App Engine
This is Rietveld 408576698