Issue 7080029: Fix Issue 1320: LiveEdit: text differencer fails with out of memory on large files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7080029: Fix Issue 1320: LiveEdit: text differencer fails with out of memory on large files (Closed)

Created:
9 years, 6 months ago by Peter Rybin

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix Issue 1320: LiveEdit: text differencer fails with out of memory on large files

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : clean #

Patch Set 4 : tests #

Patch Set 5 : wrap string exception in failure #

Patch Set 6 : merge #

Total comments: 3

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -25 lines)			Patch
M	src/liveedit.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/liveedit.cc	View	1 2 3 4 5	6 chunks	+84 lines, -17 lines	3 comments	Download
M	src/liveedit-debugger.js	View	1 2 3 4	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-liveedit.cc	View	1 2 3	1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 6 months ago (2011-05-31 08:03:09 UTC) #2

LGTM

http://codereview.chromium.org/7080029/diff/6001/src/liveedit.cc
File src/liveedit.cc (right):

http://codereview.chromium.org/7080029/diff/6001/src/liveedit.cc#newcode518
src/liveedit.cc:518: MaybeObject* res =
Comparator::CalculateDifference(&tokens_input,
All arguments on same line or each argument on separate lines.

http://codereview.chromium.org/7080029/diff/6001/src/liveedit.cc#newcode556
src/liveedit.cc:556: TokenizingLineArrayCompareOutput output(line_ends1,
line_ends2, s1, s2,
All arguments on same line or each argument on separate lines.

http://codereview.chromium.org/7080029/diff/6001/src/liveedit.cc#newcode559
src/liveedit.cc:559: MaybeObject* result =
Comparator::CalculateDifference(&input, &output,
All arguments on same line or each argument on separate lines.

Expand Messages | Collapse Messages