Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: src/liveedit.h

Issue 7080029: Fix Issue 1320: LiveEdit: text differencer fails with out of memory on large files (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: merge Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/liveedit.cc » ('j') | src/liveedit.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/liveedit.h
diff --git a/src/liveedit.h b/src/liveedit.h
index 60e6238c80420f4cce490373de01e2f86c1d552c..3b19ac6775068450423e4ff662a1b419074b2469 100644
--- a/src/liveedit.h
+++ b/src/liveedit.h
@@ -135,8 +135,8 @@ class LiveEdit : AllStatic {
// Compares 2 strings line-by-line, then token-wise and returns diff in form
// of array of triplets (pos1, pos1_end, pos2_end) describing list
// of diff chunks.
- static Handle<JSArray> CompareStrings(Handle<String> s1,
- Handle<String> s2);
+ static MUST_USE_RESULT MaybeObject/*<JSArray>*/* CompareStrings(
+ Handle<String> s1, Handle<String> s2);
};
@@ -168,8 +168,8 @@ class Comparator {
};
// Finds the difference between 2 arrays of elements.
- static void CalculateDifference(Input* input,
- Output* result_writer);
+ static MUST_USE_RESULT MaybeObject/*<void>*/* CalculateDifference(
+ Input* input, Output* result_writer, Isolate* isolate);
};
#endif // ENABLE_DEBUGGER_SUPPORT
« no previous file with comments | « no previous file | src/liveedit.cc » ('j') | src/liveedit.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698