Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 7075005: Revert 86802 - Remove ProtocolFactory/Interceptor uses in GViewRequestInterceptor. (Closed)

Created:
9 years, 7 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 86802 - Remove ProtocolFactory/Interceptor uses in GViewRequestInterceptor. Gets rid of more use of net/ globals, replacing with URLRequestJobFactory uses. Helps make net/ more thread-compatible. BUG=81979 TEST=none Review URL: http://codereview.chromium.org/7019030 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -152 lines) Patch
M chrome/browser/chromeos/gview_request_interceptor.h View 3 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.cc View 3 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 10 chunks +14 lines, -28 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/url_request/url_request_job_factory.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/url_request/url_request_job_factory.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M net/url_request/url_request_job_manager.cc View 3 chunks +16 lines, -48 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
willchan no longer on Chromium
9 years, 7 months ago (2011-05-26 09:50:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698