Issue 7019030: Remove ProtocolFactory/Interceptor uses in GViewRequestInterceptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7019030: Remove ProtocolFactory/Interceptor uses in GViewRequestInterceptor (Closed)

Created:
9 years, 7 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Scott Byer

CC:
chromium-reviews, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove ProtocolFactory/Interceptor uses in GViewRequestInterceptor. Gets rid of more use of net/ globals, replacing with URLRequestJobFactory uses. Helps make net/ more thread-compatible. BUG=81979 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86802 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86804

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -74 lines)			Patch
M	chrome/browser/chromeos/gview_request_interceptor.h	View	1 2 3	3 chunks	+14 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/gview_request_interceptor.cc	View	1	3 chunks	+13 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/gview_request_interceptor_unittest.cc	View	1 2	10 chunks	+28 lines, -14 lines	0 comments	Download
M	chrome/browser/profiles/profile_io_data.cc	View	1 2 3 4	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View	1 2 3 4	1 chunk	+0 lines, -6 lines	0 comments	Download
M	net/url_request/url_request_job_factory.h	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_job_factory.cc	View	1 2 3 4	1 chunk	+33 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_job_manager.h	View	1 2 3 4	2 chunks	+0 lines, -2 lines	0 comments	Download
M	net/url_request/url_request_job_manager.cc	View	1 2 3 4	6 chunks	+48 lines, -22 lines	0 comments	Download

Total messages: 2 (0 generated)

Scott Byer

9 years, 7 months ago (2011-05-23 21:43:31 UTC) #2

LGTM for the interceptor changes. The factory changes look good too, but I'm not
an expert in that area.

On 2011/05/22 22:19:28, willchan wrote: