Get rid of content dependency from sandbox_policy.h

Get rid of content dependency from sandbox_policy.h

BUG=76697
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87093

[nsylvain, 2011-05-27 15:55:46]

according to the try jobs, pretty much all plugin tests are failing on Windows

[jam, 2011-05-27 15:58:08]

I'll make sure it's all green before commit :)  I sent the review in
parallel with running the try jobs.

On Fri, May 27, 2011 at 8:55 AM, <nsylvain@google.com> wrote:

> according to the try jobs, pretty much all plugin tests are failing on
> Windows
>
>
> http://codereview.chromium.org/7074025/
>

[nsylvain, 2011-05-27 19:51:14]

LGTM.

Carlos: No plans to support the flash sandbox on XP ? If so, we'd need to kind
in mind some of the code that is gone to support running plugins in the sandbox
on XP.

[cpu_(ooo_6.6-7.5), 2011-05-27 20:19:09]

http://codereview.chromium.org/7074025/diff/9002/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.h (right):

http://codereview.chromium.org/7074025/diff/9002/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.h:48: #if defined(OS_WIN)
the code only sandboxes flash, so there should be a comment about that here. I
guess is work-in-progress.

http://codereview.chromium.org/7074025/diff/9002/chrome/common/sandbox_policy.cc
File chrome/common/sandbox_policy.cc (right):

http://codereview.chromium.org/7074025/diff/9002/chrome/common/sandbox_policy...
chrome/common/sandbox_policy.cc:401: if (!in_sandbox) {
needs to be above.

http://codereview.chromium.org/7074025/diff/9002/sandbox/src/sandbox_policy_b...
File sandbox/src/sandbox_policy_base.h (left):

http://codereview.chromium.org/7074025/diff/9002/sandbox/src/sandbox_policy_b...
sandbox/src/sandbox_policy_base.h:34: ~PolicyBase();
I see a PolicyBase::~PolicyBase() in sandbox_policy_base.cc

[jam, 2011-05-27 20:25:53]

http://codereview.chromium.org/7074025/diff/9002/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.h (right):

http://codereview.chromium.org/7074025/diff/9002/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.h:48: #if defined(OS_WIN)
On 2011/05/27 20:19:09, cpu wrote:
> the code only sandboxes flash, so there should be a comment about that here. I
> guess is work-in-progress.

we normally only comment the content interface functions.  for the chrome
implementation, we put comments in the cc file (similar to the webkit api)

http://codereview.chromium.org/7074025/diff/9002/chrome/common/sandbox_policy.cc
File chrome/common/sandbox_policy.cc (right):

http://codereview.chromium.org/7074025/diff/9002/chrome/common/sandbox_policy...
chrome/common/sandbox_policy.cc:401: if (!in_sandbox) {
On 2011/05/27 20:19:09, cpu wrote:
> needs to be above.

we don't know if we'll need to call LaunchApp or not until after calling to the
embedder.  i added a check for kNoSandbox above

http://codereview.chromium.org/7074025/diff/9002/sandbox/src/sandbox_policy_b...
File sandbox/src/sandbox_policy_base.h (left):

http://codereview.chromium.org/7074025/diff/9002/sandbox/src/sandbox_policy_b...
sandbox/src/sandbox_policy_base.h:34: ~PolicyBase();
On 2011/05/27 20:19:09, cpu wrote:
> I see a PolicyBase::~PolicyBase() in sandbox_policy_base.cc

I just moved this to be private, since the class is refcounted

[cpu_(ooo_6.6-7.5), 2011-05-27 21:25:44]

lgtm

Nicolas fire an email to me/jam with the things you think we can get rid of. I
don't plan to support XP.