Issue 7074018: Implement Chromium version of WebCore::MediaPlayer::mediaTimeForTimeValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7074018: Implement Chromium version of WebCore::MediaPlayer::mediaTimeForTimeValue() (Closed)

Created:
9 years, 7 months ago by acolwell GONE FROM CHROMIUM

Modified:
9 years, 6 months ago

Reviewers:
vrk (LEFT CHROMIUM), sjl

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Implement Chromium version of WebCore::MediaPlayer::mediaTimeForTimeValue() BUG=61166 TEST=media/video-seek-by-small-increment.html Layout Test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86911

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	webkit/glue/webmediaplayer_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	webkit/glue/webmediaplayer_impl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

This method simply rounds a float to TimeDelta units. This is needed by WebKit to ...

9 years, 7 months ago (2011-05-26 20:36:43 UTC) #1

LGTM

Expand Messages | Collapse Messages