Issue 7071002: Revert "Add VideoCaptureImpl and VideoCaptureImplManager"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7071002: Revert "Add VideoCaptureImpl and VideoCaptureImplManager" (Closed)

Created:
9 years, 7 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
wjia1, wjia(left Chromium)

CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., jam, joi+watch-content_chromium.org, acolwell GONE FROM CHROMIUM, annacc, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Revert "Add VideoCaptureImpl and VideoCaptureImplManager" This reverts commit r86758 Revert "fix clang" This reverts commit r86761 BUG=NONE TEST=NONE TBR=wjia@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86770

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -850 lines)			Patch
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/content_renderer.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	content/renderer/media/video_capture_impl.h	View	1 chunk	+0 lines, -111 lines	0 comments	Download
D	content/renderer/media/video_capture_impl.cc	View	1 chunk	+0 lines, -386 lines	0 comments	Download
D	content/renderer/media/video_capture_impl_manager.h	View	1 chunk	+0 lines, -68 lines	0 comments	Download
D	content/renderer/media/video_capture_impl_manager.cc	View	1 chunk	+0 lines, -118 lines	0 comments	Download
D	content/renderer/media/video_capture_impl_unittest.cc	View	1 chunk	+0 lines, -107 lines	0 comments	Download
M	content/renderer/video_capture_message_filter.h	View	3 chunks	+3 lines, -8 lines	0 comments	Download
M	content/renderer/video_capture_message_filter.cc	View	3 chunks	+3 lines, -21 lines	0 comments	Download
M	content/renderer/video_capture_message_filter_unittest.cc	View	11 chunks	+11 lines, -26 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wjia(left Chromium)

9 years, 7 months ago (2011-05-26 03:36:27 UTC) #2

On 2011/05/26 02:03:36, vandebo wrote:

Please revert this change. r86761 has fixed r86758's clang problem.

Expand Messages | Collapse Messages