Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: content/renderer/video_capture_message_filter_unittest.cc

Issue 7071002: Revert "Add VideoCaptureImpl and VideoCaptureImplManager" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/video_capture_message_filter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/video_capture_message_filter_unittest.cc
diff --git a/content/renderer/video_capture_message_filter_unittest.cc b/content/renderer/video_capture_message_filter_unittest.cc
index 1d647db9a45f906d8dcc4e1b3c242ddc73edfdda..d41c709d220303232274339aa2c38e6c453e0811 100644
--- a/content/renderer/video_capture_message_filter_unittest.cc
+++ b/content/renderer/video_capture_message_filter_unittest.cc
@@ -13,8 +13,6 @@ class MockVideoCaptureDelegate : public VideoCaptureMessageFilter::Delegate {
public:
MockVideoCaptureDelegate() {
Reset();
- device_id_received_ = false;
- device_id_ = 0;
}
virtual void OnBufferReceived(TransportDIB::Handle handle,
@@ -36,11 +34,6 @@ class MockVideoCaptureDelegate : public VideoCaptureMessageFilter::Delegate {
params_.frame_per_second = params.frame_per_second;
}
- virtual void OnDelegateAdded(int32 device_id) {
- device_id_received_ = true;
- device_id_ = device_id;
- }
-
void Reset() {
buffer_received_ = false;
handle_ = TransportDIB::DefaultHandleValue();
@@ -65,9 +58,6 @@ class MockVideoCaptureDelegate : public VideoCaptureMessageFilter::Delegate {
bool device_info_receive() { return device_info_received_; }
const media::VideoCaptureParams& received_device_info() { return params_; }
- bool device_id_received() { return device_id_received_; }
- int32 device_id() { return device_id_; }
-
private:
bool buffer_received_;
TransportDIB::Handle handle_;
@@ -79,9 +69,6 @@ class MockVideoCaptureDelegate : public VideoCaptureMessageFilter::Delegate {
bool device_info_received_;
media::VideoCaptureParams params_;
- bool device_id_received_;
- int32 device_id_;
-
DISALLOW_COPY_AND_ASSIGN(MockVideoCaptureDelegate);
};
@@ -93,15 +80,14 @@ TEST(VideoCaptureMessageFilterTest, Basic) {
const int kRouteId = 0;
scoped_refptr<VideoCaptureMessageFilter> filter(
new VideoCaptureMessageFilter(kRouteId));
- filter->channel_ = reinterpret_cast<IPC::Channel*>(1);
MockVideoCaptureDelegate delegate;
- filter->AddDelegate(&delegate);
+ int device_id = filter->AddDelegate(&delegate);
// VideoCaptureMsg_StateChanged
EXPECT_FALSE(delegate.state_changed_received());
filter->OnMessageReceived(
- VideoCaptureMsg_StateChanged(kRouteId, delegate.device_id(),
+ VideoCaptureMsg_StateChanged(kRouteId, device_id,
media::VideoCapture::kStarted));
EXPECT_TRUE(delegate.state_changed_received());
EXPECT_TRUE(media::VideoCapture::kStarted == delegate.state());
@@ -113,7 +99,7 @@ TEST(VideoCaptureMessageFilterTest, Basic) {
EXPECT_FALSE(delegate.buffer_received());
filter->OnMessageReceived(VideoCaptureMsg_BufferReady(
- kRouteId, delegate.device_id(), handle, timestamp));
+ kRouteId, device_id, handle, timestamp));
EXPECT_TRUE(delegate.buffer_received());
#if defined(OS_MACOSX)
EXPECT_EQ(handle.fd, delegate.received_buffer_handle().fd);
@@ -131,7 +117,7 @@ TEST(VideoCaptureMessageFilterTest, Basic) {
EXPECT_FALSE(delegate.device_info_receive());
filter->OnMessageReceived(VideoCaptureMsg_DeviceInfo(
- kRouteId, delegate.device_id(), params));
+ kRouteId, device_id, params));
EXPECT_TRUE(delegate.device_info_receive());
EXPECT_EQ(params.width, delegate.received_device_info().width);
EXPECT_EQ(params.height, delegate.received_device_info().height);
@@ -148,19 +134,18 @@ TEST(VideoCaptureMessageFilterTest, Delegates) {
const int kRouteId = 0;
scoped_refptr<VideoCaptureMessageFilter> filter(
new VideoCaptureMessageFilter(kRouteId));
- filter->channel_ = reinterpret_cast<IPC::Channel*>(1);
MockVideoCaptureDelegate delegate1;
MockVideoCaptureDelegate delegate2;
- filter->AddDelegate(&delegate1);
- filter->AddDelegate(&delegate2);
+ int device_id1 = filter->AddDelegate(&delegate1);
+ int device_id2 = filter->AddDelegate(&delegate2);
// Send an IPC message. Make sure the correct delegate gets called.
EXPECT_FALSE(delegate1.state_changed_received());
EXPECT_FALSE(delegate2.state_changed_received());
filter->OnMessageReceived(
- VideoCaptureMsg_StateChanged(kRouteId, delegate1.device_id(),
+ VideoCaptureMsg_StateChanged(kRouteId, device_id1,
media::VideoCapture::kStarted));
EXPECT_TRUE(delegate1.state_changed_received());
EXPECT_FALSE(delegate2.state_changed_received());
@@ -169,7 +154,7 @@ TEST(VideoCaptureMessageFilterTest, Delegates) {
EXPECT_FALSE(delegate1.state_changed_received());
EXPECT_FALSE(delegate2.state_changed_received());
filter->OnMessageReceived(
- VideoCaptureMsg_StateChanged(kRouteId, delegate2.device_id(),
+ VideoCaptureMsg_StateChanged(kRouteId, device_id2,
media::VideoCapture::kStarted));
EXPECT_FALSE(delegate1.state_changed_received());
EXPECT_TRUE(delegate2.state_changed_received());
@@ -178,7 +163,7 @@ TEST(VideoCaptureMessageFilterTest, Delegates) {
// Send a message of a different route id, a message is not received.
EXPECT_FALSE(delegate1.state_changed_received());
filter->OnMessageReceived(
- VideoCaptureMsg_StateChanged(kRouteId+1, delegate1.device_id(),
+ VideoCaptureMsg_StateChanged(kRouteId+1, device_id1,
media::VideoCapture::kStarted));
EXPECT_FALSE(delegate1.state_changed_received());
@@ -186,14 +171,14 @@ TEST(VideoCaptureMessageFilterTest, Delegates) {
filter->RemoveDelegate(&delegate1);
EXPECT_FALSE(delegate1.state_changed_received());
filter->OnMessageReceived(
- VideoCaptureMsg_StateChanged(kRouteId, delegate1.device_id(),
+ VideoCaptureMsg_StateChanged(kRouteId, device_id1,
media::VideoCapture::kStarted));
EXPECT_FALSE(delegate1.state_changed_received());
filter->RemoveDelegate(&delegate2);
EXPECT_FALSE(delegate2.state_changed_received());
filter->OnMessageReceived(
- VideoCaptureMsg_StateChanged(kRouteId, delegate2.device_id(),
+ VideoCaptureMsg_StateChanged(kRouteId, device_id2,
media::VideoCapture::kStarted));
EXPECT_FALSE(delegate2.state_changed_received());
« no previous file with comments | « content/renderer/video_capture_message_filter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698