Issue 7068034: Remove the last prefs code from content. I tried hard to move ShouldShowBookmarkBar out of TabCo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7068034: Remove the last prefs code from content. I tried hard to move ShouldShowBookmarkBar out of TabCo... (Closed)

Created:
9 years, 7 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, estade+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Remove the last prefs code from content. I tried hard to move ShouldShowBookmarkBar out of TabContents, but this looked very tricky so I've punted and filed http://crbug.com/83975 to track that. BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86779

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -22 lines)			Patch
M	chrome/browser/chrome_content_browser_client.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	content/browser/DEPS	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	content/browser/content_browser_client.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/content_browser_client.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	1	5 chunks	+5 lines, -15 lines	0 comments	Download

Total messages: 2 (0 generated)

Whoo! LGTM