chrome/browser/ui/webui/ntp/new_tab_ui.cc - Issue 7068034: Remove the last prefs code from content. I tried hard to move ShouldShowBookmarkBar out of TabCo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_ui.cc

Issue 7068034: Remove the last prefs code from content. I tried hard to move ShouldShowBookmarkBar out of TabCo... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/ntp/new_tab_ui.cc

===================================================================

--- chrome/browser/ui/webui/ntp/new_tab_ui.cc (revision 86679)

+++ chrome/browser/ui/webui/ntp/new_tab_ui.cc (working copy)

@@ -16,6 +16,7 @@

#include "base/string_number_conversions.h"

#include "base/threading/thread.h"

#include "base/utf_string_conversions.h"

+#include "chrome/browser/defaults.h"

#include "chrome/browser/metrics/metric_event_duration_details.h"

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/profiles/profile.h"

@@ -318,8 +319,11 @@

// Override some options on the Web UI.

hide_favicon_ = true;

- if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kNewTabPage4))

+ if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kNewTabPage4) &&

+ GetProfile()->GetPrefs()->GetBoolean(prefs::kEnableBookmarkBar) &&

+ browser_defaults::bookmarks_enabled) {

force_bookmark_bar_visible_ = true;

+ }

focus_location_bar_by_default_ = true;

should_hide_url_ = true;

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | content/browser/DEPS » ('j') | no next file with comments »