Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2160)

Unified Diff: functional/browser.py

Issue 7068032: Adding a pyauto test, testPopupSharesProcessWithIncognito, in browser.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/test/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: functional/browser.py
===================================================================
--- functional/browser.py (revision 85822)
+++ functional/browser.py (working copy)
@@ -229,6 +229,18 @@
self.assertNotEqual(shared_pid,
self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid'])
+ def testPopupSharesProcessWithIncognito(self):
anantha 2011/05/26 23:10:57 can we rename to: testPopupSharesSameProcessInInco
jasneet 2011/06/03 21:11:08 Done.
+ "Launch Popup in incognito window"
anantha 2011/05/26 23:10:57 Please give a one line description of what this te
jasneet 2011/06/03 21:11:08 Done.
+ self.RunCommand(pyauto.IDC_NEW_INCOGNITO_WINDOW)
+ file_url = self.GetFileURLForPath(os.path.join(
Nirnimesh 2011/05/27 07:16:13 self.GetFileURLForDataPath('popup_blocker', 'popup
jasneet 2011/06/03 21:11:08 Done.
+ self.DataDir(), 'popup_blocker', 'popup-window-open.html'))
+ self.NavigateToURL(file_url, 1, 0)
+ self.UnblockAndLaunchBlockedPopup(0, tab_index=0, windex=1)
Nirnimesh 2011/05/27 07:16:13 The next line should be a comment, not a string
jasneet 2011/06/03 21:11:08 Deleted this comment
+ "Verify parent incognito and popup share same process id"
anantha 2011/05/26 23:10:57 Please get rid of these variables. Instead include
jasneet 2011/06/03 21:11:08 Done.
+ incog_pid = self.GetBrowserInfo()['windows'][1]['tabs'][0]['renderer_pid']
+ popup_pid = self.GetBrowserInfo()['windows'][2]['tabs'][0]['renderer_pid']
+ self.assertEquals(popup_pid, incog_pid,
+ msg='Incognito window and popup are not sharing a process id.')
if __name__ == '__main__':
pyauto_functional.Main()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698