Adding a pyauto test, testPopupSharesProcessWithIncognito, in browser.py

functional/browser.py

 #!/usr/bin/python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 import types
 
 import pyauto_functional  # Must be imported before pyauto
@@ skipping 211 matching lines @@
     self.GetBrowserWindow(0).GetTab(0).Reload()
     self.GetBrowserWindow(1).GetTab(0).Reload()
     # Check if both are sharing a process id.
     self.assertEquals(
         self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid'],
         self.GetBrowserInfo()['windows'][1]['tabs'][0]['renderer_pid'])
     # The shared process id should be different from the previous one.
     self.assertNotEqual(shared_pid,
         self.GetBrowserInfo()['windows'][0]['tabs'][0]['renderer_pid'])
 
+  def testPopupSharesProcessWithIncognito(self):

[anantha, 2011/05/26 23:10:57]

can we rename to: testPopupSharesSameProcessInIncognito

[jasneet, 2011/06/03 21:11:08]

Done.

+    "Launch Popup in incognito window"

[anantha, 2011/05/26 23:10:57]

Please give a one line description of what this test is doing. 

[jasneet, 2011/06/03 21:11:08]

Done.

+    self.RunCommand(pyauto.IDC_NEW_INCOGNITO_WINDOW)
+    file_url = self.GetFileURLForPath(os.path.join(

[Nirnimesh, 2011/05/27 07:16:13]

self.GetFileURLForDataPath('popup_blocker', 'popup-window-open.html')

[jasneet, 2011/06/03 21:11:08]

Done.

+        self.DataDir(), 'popup_blocker', 'popup-window-open.html'))
+    self.NavigateToURL(file_url, 1, 0)
+    self.UnblockAndLaunchBlockedPopup(0, tab_index=0, windex=1)

[Nirnimesh, 2011/05/27 07:16:13]

The next line should be a comment, not a string

[jasneet, 2011/06/03 21:11:08]

Deleted this comment

+    "Verify parent incognito and popup share same process id"

[anantha, 2011/05/26 23:10:57]

Please get rid of these variables. Instead include self.GetBrowserInfo... in
self.assertEquals(..
Take a look at lines: 214 to 216.

[jasneet, 2011/06/03 21:11:08]

Done.

+    incog_pid = self.GetBrowserInfo()['windows'][1]['tabs'][0]['renderer_pid']
+    popup_pid = self.GetBrowserInfo()['windows'][2]['tabs'][0]['renderer_pid']
+    self.assertEquals(popup_pid, incog_pid,
+        msg='Incognito window and popup are not sharing a process id.')
 
 if __name__ == '__main__':
   pyauto_functional.Main()