Adding a pyauto test, testPopupSharesProcessWithIncognito, in browser.py

Adding a pyauto test, testPopupSharesProcessWithIncognito, in browser.py

BUG=NONE
TEST=NONE

This test is to verify that popup process launched through incognito shares a process id with it's parent process

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88429

[anantha, 2011-05-26 23:10:57]

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py
File functional/browser.py (right):

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py#newcod...
functional/browser.py:232: def testPopupSharesProcessWithIncognito(self):
can we rename to: testPopupSharesSameProcessInIncognito

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py#newcod...
functional/browser.py:233: "Launch Popup in incognito window"
Please give a one line description of what this test is doing.

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py#newcod...
functional/browser.py:239: "Verify parent incognito and popup share same process
id"
Please get rid of these variables. Instead include self.GetBrowserInfo... in
self.assertEquals(..
Take a look at lines: 214 to 216.

[Nirnimesh, 2011-05-27 07:16:13]

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py
File functional/browser.py (right):

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py#newcod...
functional/browser.py:235: file_url = self.GetFileURLForPath(os.path.join(
self.GetFileURLForDataPath('popup_blocker', 'popup-window-open.html')

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py#newcod...
functional/browser.py:238: self.UnblockAndLaunchBlockedPopup(0, tab_index=0,
windex=1)
The next line should be a comment, not a string

[jasneet, 2011-06-03 21:11:08]

Done with the changes. Please review.

Thanks
Jasneet

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py
File functional/browser.py (right):

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py#newcod...
functional/browser.py:232: def testPopupSharesProcessWithIncognito(self):
On 2011/05/26 23:10:57, anantha wrote:
> can we rename to: testPopupSharesSameProcessInIncognito

Done.

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py#newcod...
functional/browser.py:233: "Launch Popup in incognito window"
On 2011/05/26 23:10:57, anantha wrote:
> Please give a one line description of what this test is doing. 

Done.

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py#newcod...
functional/browser.py:235: file_url = self.GetFileURLForPath(os.path.join(
On 2011/05/27 07:16:13, Nirnimesh wrote:
> self.GetFileURLForDataPath('popup_blocker', 'popup-window-open.html')

Done.

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py#newcod...
functional/browser.py:238: self.UnblockAndLaunchBlockedPopup(0, tab_index=0,
windex=1)
On 2011/05/27 07:16:13, Nirnimesh wrote:
> The next line should be a comment, not a string

Deleted this comment

http://codereview.chromium.org/7068032/diff/1001/functional/browser.py#newcod...
functional/browser.py:239: "Verify parent incognito and popup share same process
id"
On 2011/05/26 23:10:57, anantha wrote:
> Please get rid of these variables. Instead include self.GetBrowserInfo... in
> self.assertEquals(..
> Take a look at lines: 214 to 216.

Done.

[Nirnimesh, 2011-06-08 01:34:32]

LGTM. Use the 'Commit:' checkbox to commit.

http://codereview.chromium.org/7068032/diff/6002/functional/browser.py
File functional/browser.py (right):

http://codereview.chromium.org/7068032/diff/6002/functional/browser.py#newcod...
functional/browser.py:232: def testPopupSharesSameProcessInIncognito(self):
Move this test right after testPopupSharesProcess

[commit-bot: I haz the power, 2011-06-08 21:14:03]

Presubmit check for 7068032-12001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Found a tab character in:

***************
chrome/test/functional/browser.py, line 163
***************

Found line ending with white spaces in:

***************
chrome/test/functional/browser.py, line 156
chrome/test/functional/browser.py, line 161
***************

Presubmit checks took 1.1s to calculate.

[Nirnimesh, 2011-06-08 21:17:39]

Please fix these errors and re-try.

[commit-bot: I haz the power, 2011-06-08 21:46:52]

Presubmit check for 7068032-13002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found a tab character in:

***************
chrome/test/functional/browser.py, line 163
***************

Found line ending with white spaces in:

***************
chrome/test/functional/browser.py, line 156
chrome/test/functional/browser.py, line 161
***************

[commit-bot: I haz the power, 2011-06-08 22:23:08]

Presubmit check for 7068032-13003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found a tab character in:

***************
chrome/test/functional/browser.py, line 163
***************

Found line ending with white spaces in:

***************
chrome/test/functional/browser.py, line 156
chrome/test/functional/browser.py, line 161
***************

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Nirnimesh, 2011-06-08 22:32:51]

http://codereview.chromium.org/7068032/diff/13003/functional/browser.py
File functional/browser.py (right):

http://codereview.chromium.org/7068032/diff/13003/functional/browser.py#newco...
functional/browser.py:200: file_url =
self.GetFileURLForDataPath('popup_blocker',
There's stray spaces at the end of thisline

[commit-bot: I haz the power, 2011-06-08 22:44:29]

Presubmit check for 7068032-15002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found a tab character in:

***************
chrome/test/functional/browser.py, line 163
***************

[Nirnimesh, 2011-06-08 22:46:28]

Let me take care of this CL for you.

[Nirnimesh, 2011-06-08 22:50:21]

Committed

[jasneet, 2011-06-08 22:51:10]

On 2011/06/08 22:46:28, Nirnimesh wrote:
> Let me take care of this CL for you.

Sorry about that.I looked at line 163 but don't see a tab char.

thanks a lot..

[jasneet1, 2011-06-08 22:53:32]

thanks a lot.

On Wed, Jun 8, 2011 at 3:50 PM, <nirnimesh@chromium.org> wrote:

> Committed
>
>
>
http://codereview.chromium.**org/7068032/<http://codereview.chromium.org/7068...
>