Issue 7067037: Enabled nacl_integration tests on the Linux bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7067037: Enabled nacl_integration tests on the Linux bots. (Closed)

Created:
9 years, 7 months ago by Nick Bray

Modified:
9 years, 7 months ago

Reviewers:
Mark Seaborn, commit-bot: I haz the power, brettw

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Enabled nacl_integration tests on the Linux bots. Added an easy hook for enabling / disabling the tests as needed. BUG= none TEST= none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86633

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mark's edit #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	chrome/test/nacl_test_injection/buildbot_nacl_integration.py	View	1	1 chunk	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

LGTM http://codereview.chromium.org/7067037/diff/1/chrome/test/nacl_test_injection/buildbot_nacl_integration.py File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right): http://codereview.chromium.org/7067037/diff/1/chrome/test/nacl_test_injection/buildbot_nacl_integration.py#newcode13 chrome/test/nacl_test_injection/buildbot_nacl_integration.py:13: integration_bot = 'nacl-chrome' in pwd Maybe "is_integration_bot"? http://codereview.chromium.org/7067037/diff/1/chrome/test/nacl_test_injection/buildbot_nacl_integration.py#newcode21 ...

9 years, 7 months ago (2011-05-24 20:57:13 UTC) #2

commit-bot: I haz the power

Try job failure for 7067037-2002 on mac: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=28726

9 years, 7 months ago (2011-05-25 00:05:05 UTC) #4

Change committed as 86633

Expand Messages | Collapse Messages