Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/test/nacl_test_injection/buildbot_nacl_integration.py

Issue 7067037: Enabled nacl_integration tests on the Linux bots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mark's edit Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/nacl_test_injection/buildbot_nacl_integration.py
diff --git a/chrome/test/nacl_test_injection/buildbot_nacl_integration.py b/chrome/test/nacl_test_injection/buildbot_nacl_integration.py
index d7e929ae5fc8efab8631c5556782e3983511702b..fbbcf5331605aa1432090348e35bb4c93545e229 100755
--- a/chrome/test/nacl_test_injection/buildbot_nacl_integration.py
+++ b/chrome/test/nacl_test_injection/buildbot_nacl_integration.py
@@ -10,12 +10,20 @@ import sys
def Main():
pwd = os.environ.get('PWD', '')
- # TODO(ncbray): figure out why this is failing on windows and enable.
- if sys.platform in ['win32', 'cygwin'] and 'nacl-chrome' not in pwd: return
- # TODO(ncbray): figure out why this is failing on mac and re-enable.
- if sys.platform == 'darwin' and 'nacl-chrome' not in pwd: return
- # TODO(ncbray): figure out why this is failing on some linux trybots.
- if sys.platform in ['linux', 'linux2'] and 'nacl-chrome' not in pwd: return
+ is_integration_bot = 'nacl-chrome' in pwd
+
+ if not is_integration_bot:
+ # On the main Chrome waterfall, we may need to control where the tests are
+ # run.
+
+ # TODO(ncbray): enable on all platforms.
+ if sys.platform in ['win32', 'cygwin']: return
+ if sys.platform == 'darwin': return
+ # if sys.platform in ['linux', 'linux2']: return
+
+ # Uncomment the following line if there is skew in the PPAPI interface
+ # and the tests are failing. Comment out once the issues are resolved.
+ # return
script_dir = os.path.dirname(os.path.abspath(__file__))
test_dir = os.path.dirname(script_dir)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698