Issue 7067031: roll skia 1402:1410

Issue 7067031: roll skia 1402:1410 (Closed)

Created:
9 years, 7 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
epoger, reed1

CC:
chromium-reviews, skia-review_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

roll skia 1402:1410 http://code.google.com/p/skia/source/detail?r=1405 make SkIntToScalar more strict (it no longer allows double arguments), so the roll requires a minor code change. BUG=none TEST=none TBR=epoger Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86489 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86545

Patch Set 5 : post revert #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	DEPS	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/create_application_shortcut_view.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/extension_action.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	skia/ext/canvas_paint_mac.h	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

reed1

http://codereview.chromium.org/7067031/diff/1003/chrome/common/extensions/extension_action.cc File chrome/common/extensions/extension_action.cc (right): http://codereview.chromium.org/7067031/diff/1003/chrome/common/extensions/extension_action.cc#newcode151 chrome/common/extensions/extension_action.cc:151: SkIntToScalar(badge_width / 2))); I think we're losing the fraction ...

9 years, 7 months ago (2011-05-24 21:09:45 UTC) #2

reed1

"Don't" we want (sorry, can't spell). On 2011/05/24 21:09:45, reed1 wrote: > http://codereview.chromium.org/7067031/diff/1003/chrome/common/extensions/extension_action.cc > File ...

9 years, 7 months ago (2011-05-24 21:11:25 UTC) #3

epoger

9 years, 7 months ago (2011-05-24 21:16:20 UTC) #4

Nico

9 years, 7 months ago (2011-05-24 21:17:35 UTC) #5

http://codereview.chromium.org/7067031/diff/1003/chrome/common/extensions/ext...
File chrome/common/extensions/extension_action.cc (right):

http://codereview.chromium.org/7067031/diff/1003/chrome/common/extensions/ext...
chrome/common/extensions/extension_action.cc:151: SkIntToScalar(badge_width /
2)));
On 2011/05/24 21:09:45, reed1 wrote:
> I think we're losing the fraction part with this change. Done we want
> 
> SkIntToScalar(bounds.width()) / 2
> 
> (same for badge_width)

Will do.

Expand Messages | Collapse Messages