roll skia 1402:1410

chrome/common/extensions/extension_action.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_action.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "chrome/common/badge_util.h"
@@ skipping 129 matching lines @@
   badge_width = std::max(kBadgeHeight, badge_width);
 
   // Paint the badge background color in the right location. It is usually
   // right-aligned, but it can also be center-aligned if it is large.
   SkRect rect;
   rect.fBottom = SkIntToScalar(bounds.bottom() - kBottomMargin);
   rect.fTop = rect.fBottom - SkIntToScalar(kBadgeHeight);
   if (badge_width >= kCenterAlignThreshold) {
     rect.fLeft = SkIntToScalar(
                      SkScalarFloor(SkIntToScalar(bounds.x()) +
-                                   SkIntToScalar(bounds.width() / 2.0) -
-                                   SkIntToScalar(badge_width / 2.0)));
+                                   SkIntToScalar(bounds.width() / 2) -
+                                   SkIntToScalar(badge_width / 2)));

[reed1, 2011/05/24 21:09:45]

I think we're losing the fraction part with this change. Done we want

SkIntToScalar(bounds.width()) / 2

(same for badge_width)

[epoger, 2011/05/24 21:16:21]

I agree with Mike... either that, or...
SkDoubleToScalar(bounds.width() / 2.0)

[Nico, 2011/05/24 21:17:35]

Will do.

     rect.fRight = rect.fLeft + SkIntToScalar(badge_width);
   } else {
     rect.fRight = SkIntToScalar(bounds.right());
     rect.fLeft = rect.fRight - badge_width;
   }
 
   SkPaint rect_paint;
   rect_paint.setStyle(SkPaint::kFill_Style);
   rect_paint.setAntiAlias(true);
   rect_paint.setColor(background_color);
@@ skipping 23 matching lines @@
   // text was too large.
   rect.fLeft += kPadding;
   rect.fRight -= kPadding;
   canvas->AsCanvasSkia()->clipRect(rect);
   canvas->AsCanvasSkia()->drawText(text.c_str(), text.size(),
                                    rect.fLeft + (rect.width() - text_width) / 2,
                                    rect.fTop + kTextSize + kTopTextPadding,
                                    *text_paint);
   canvas->Restore();
 }