Issue 7067029: Prototype compositor to render views to a texture using d3d 10. This

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7067029: Prototype compositor to render views to a texture using d3d 10. This (Closed)

Created:
9 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google), apatrick_chromium

CC:
chromium-reviews, Alexei Svitkine (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Prototype compositor to render views to a texture using d3d 10. This is just a prototype for us to play with. There are plenty of issues to resolve before its made real, but I wanted to check something in for others to play with rather than keeping it all local. To get it to compile you need to set the GYP_DEFINE to views_compositor. BUG=none TEST=none R=ben@chromium.org,apatrick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86516

Patch Set 1 #

Patch Set 2 : Fix gyp #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+670 lines, -1 line)			Patch
M	build/common.gypi	View	1	4 chunks	+10 lines, -0 lines	0 comments	Download
M	ui/gfx/compositor/compositor.gyp	View		2 chunks	+24 lines, -0 lines	0 comments	Download
A	ui/gfx/compositor/compositor_win.cc	View		1 chunk	+563 lines, -0 lines	0 comments	Download
M	ui/gfx/gfx_resources.grd	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	ui/gfx/resources/compositor.fx	View		1 chunk	+67 lines, -0 lines	1 comment	Download
M	views/widget/native_widget_win.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 7 months ago (2011-05-24 19:46:15 UTC) #3

LGTM

http://codereview.chromium.org/7067029/diff/8/ui/gfx/resources/compositor.fx
File ui/gfx/resources/compositor.fx (right):

http://codereview.chromium.org/7067029/diff/8/ui/gfx/resources/compositor.fx#...
ui/gfx/resources/compositor.fx:65: 0xFFFFFFFF);
nit: 1-space outdent

Expand Messages | Collapse Messages