Search all slots when looking for a key in NSS

crypto/nss_util_internal.h

Index: crypto/nss_util_internal.h
diff --git a/crypto/nss_util_internal.h b/crypto/nss_util_internal.h
index ea40fdb790a10fda37728549d01a3f9ffdd93a97..c32fa7f4bea150f921bae0513dde9be37b0ddfbb 100644
--- a/crypto/nss_util_internal.h
+++ b/crypto/nss_util_internal.h
@@ -25,6 +25,17 @@ PK11SlotInfo* GetPublicNSSKeySlot();
 // PK11_FreeSlot.
 PK11SlotInfo* GetPrivateNSSKeySlot();
 
+// A helper class that acquires the SECMOD list read lock while the
+// AutoSECMODListReadLock is in scope.
+class AutoSECMODListReadLock {
+ public:
+  AutoSECMODListReadLock();
+  ~AutoSECMODListReadLock();

[wtc, 2011/06/07 00:14:32]

Can you define the constructor and destructor inline?

Nit: add a blank line after this line to separate the
public and private sections.

[Greg Spencer (Chromium), 2011/06/07 00:28:08]

Well, I could, but then I'd have to add secmod.h (not just secmodt.h) to the
header because they use SECMOD_ calls.   I was also following the way
AutoNSSWriteLock did in nss_util.h for consistency.
Done.

+ private:
+  SECMODListLock* lock_;
+  DISALLOW_COPY_AND_ASSIGN(AutoSECMODListReadLock);
+};
+
 }  // namespace crypto
 
 #endif  // CRYPTO_NSS_UTIL_INTERNAL_H_