Search all slots when looking for a key in NSS

crypto/nss_util_internal.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CRYPTO_NSS_UTIL_INTERNAL_H_
 #define CRYPTO_NSS_UTIL_INTERNAL_H_
 #pragma once
 
 #include <secmodt.h>
 
 // These functions return a type defined in an NSS header, and so cannot be
 // declared in nss_util.h.  Hence, they are declared here.
 
 namespace crypto {
 
 // Returns a reference to the default NSS key slot for storing
 // public-key data only (e.g. server certs). Caller must release
 // returned reference with PK11_FreeSlot.
 PK11SlotInfo* GetPublicNSSKeySlot();
 
 // Returns a reference to the default slot for storing private-key and
 // mixed private-key/public-key data.  Returns a hardware (TPM) NSS
 // key slot if on ChromeOS and EnableTPMForNSS() has been called
 // successfully. Caller must release returned reference with
 // PK11_FreeSlot.
 PK11SlotInfo* GetPrivateNSSKeySlot();
 
+// A helper class that acquires the SECMOD list read lock while the
+// AutoSECMODListReadLock is in scope.
+class AutoSECMODListReadLock {
+ public:
+  AutoSECMODListReadLock();
+  ~AutoSECMODListReadLock();

[wtc, 2011/06/07 00:14:32]

Can you define the constructor and destructor inline?

Nit: add a blank line after this line to separate the
public and private sections.

[Greg Spencer (Chromium), 2011/06/07 00:28:08]

Well, I could, but then I'd have to add secmod.h (not just secmodt.h) to the
header because they use SECMOD_ calls.   I was also following the way
AutoNSSWriteLock did in nss_util.h for consistency.
Done.

+ private:
+  SECMODListLock* lock_;
+  DISALLOW_COPY_AND_ASSIGN(AutoSECMODListReadLock);
+};
+
 }  // namespace crypto
 
 #endif  // CRYPTO_NSS_UTIL_INTERNAL_H_