Issue 7066034: Fixes couple of issues with bookmarks in wrench menu:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7066034: Fixes couple of issues with bookmarks in wrench menu: (Closed)

Created:
9 years, 7 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixes couple of issues with bookmarks in wrench menu: . Crash when deleting via context menu. This was happening because BookmarkMenuDelegate didn't keep a handle to the menu item it added the items to. . If other bookmarks folder is empty it wouldn't show a menu item for (empty). . Deleting the last item in the other folder would prematurely close the menu. . Hit DCHECK when adding empty menu (long standing issue). BUG=83746 TEST=from the wrench menu on windows right click a bookmark, delete it, and make sure you don't crash. R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86634

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -3 lines)			Patch
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	View	5 chunks	+12 lines, -1 line	0 comments	Download
M	views/controls/menu/menu_item_view.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 7 months ago (2011-05-24 22:31:34 UTC) #2

LGTM

http://codereview.chromium.org/7066034/diff/1/chrome/browser/ui/views/bookmar...
File chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h (right):

http://codereview.chromium.org/7066034/diff/1/chrome/browser/ui/views/bookmar...
chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h:177: // If non-null
this is the |parent| passed to Init and is NOT owned by us.
non-NULL

Expand Messages | Collapse Messages