Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 7066011: Fix PPLT metric for the new TabContents based prerendering (Closed)

Created:
9 years, 7 months ago by tburkard
Modified:
9 years, 7 months ago
Reviewers:
cbentzel, dominich, sky
CC:
chromium-reviews, tburkard+watch_chromium.org, Avi (use Gerrit), cbentzel+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix PPLT metric for the new TabContents based prerendering R=cbentzel@chromium.org, dominich@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -7 lines) Patch
M chrome/browser/prerender/prerender_manager.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_observer.cc View 3 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/prerender/prerender_render_view_host_observer.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tburkard
Please review now.
9 years, 7 months ago (2011-05-23 21:58:15 UTC) #1
dominich
LGTM You'll need an OWNER to review for the tab_contents change.
9 years, 7 months ago (2011-05-23 22:09:34 UTC) #2
tburkard
adding sky as owner of chrome/browser/ui
9 years, 7 months ago (2011-05-23 22:13:33 UTC) #3
sky
chrome/browser/ui/tab_contents/tab_contents_wrapper.h LGTM
9 years, 7 months ago (2011-05-23 22:16:17 UTC) #4
tburkard
I will commit this for now so that we will start getting new histograms asap. ...
9 years, 7 months ago (2011-05-23 23:26:35 UTC) #5
cbentzel
9 years, 7 months ago (2011-05-24 01:10:10 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698