Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: chrome/browser/prerender/prerender_observer.cc

Issue 7066011: Fix PPLT metric for the new TabContents based prerendering (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_observer.h" 5 #include "chrome/browser/prerender/prerender_observer.h"
6 6
7 #include "base/time.h" 7 #include "base/time.h"
8 #include "chrome/browser/prerender/prerender_manager.h" 8 #include "chrome/browser/prerender/prerender_manager.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "content/browser/tab_contents/tab_contents.h" 10 #include "content/browser/tab_contents/tab_contents.h"
(...skipping 26 matching lines...) Expand all
37 IPC_MESSAGE_HANDLER(ViewHostMsg_DidStartProvisionalLoadForFrame, 37 IPC_MESSAGE_HANDLER(ViewHostMsg_DidStartProvisionalLoadForFrame,
38 OnDidStartProvisionalLoadForFrame) 38 OnDidStartProvisionalLoadForFrame)
39 IPC_END_MESSAGE_MAP() 39 IPC_END_MESSAGE_MAP()
40 return false; 40 return false;
41 } 41 }
42 42
43 void PrerenderObserver::OnDidStartProvisionalLoadForFrame(int64 frame_id, 43 void PrerenderObserver::OnDidStartProvisionalLoadForFrame(int64 frame_id,
44 bool is_main_frame, 44 bool is_main_frame,
45 bool has_opener_set, 45 bool has_opener_set,
46 const GURL& url) { 46 const GURL& url) {
47 // Don't include prerendered pages in the PPLT metric until after they are
48 // swapped in.
49 if (IsPrerendering())
50 return;
51 if (is_main_frame) { 47 if (is_main_frame) {
52 // Record the beginning of a new PPLT navigation. 48 // Record the beginning of a new PPLT navigation.
53 pplt_load_start_ = base::TimeTicks::Now(); 49 pplt_load_start_ = base::TimeTicks::Now();
54 } 50 }
55 } 51 }
56 52
57 void PrerenderObserver::DidStopLoading() { 53 void PrerenderObserver::DidStopLoading() {
58 // Don't include prerendered pages in the PPLT metric until after they are 54 // Don't include prerendered pages in the PPLT metric until after they are
59 // swapped in. 55 // swapped in.
60 if (IsPrerendering())
61 return;
62 56
63 // Compute the PPLT metric and report it in a histogram, if needed. 57 // Compute the PPLT metric and report it in a histogram, if needed.
64 if (!pplt_load_start_.is_null()) { 58 if (!pplt_load_start_.is_null() && !IsPrerendering()) {
65 PrerenderManager::RecordPerceivedPageLoadTime( 59 PrerenderManager::RecordPerceivedPageLoadTime(
66 base::TimeTicks::Now() - pplt_load_start_, tab_contents()); 60 base::TimeTicks::Now() - pplt_load_start_, tab_contents());
67 } 61 }
68 62
69 // Reset the PPLT metric. 63 // Reset the PPLT metric.
70 pplt_load_start_ = base::TimeTicks(); 64 pplt_load_start_ = base::TimeTicks();
71 } 65 }
72 66
73 PrerenderManager* PrerenderObserver::MaybeGetPrerenderManager() { 67 PrerenderManager* PrerenderObserver::MaybeGetPrerenderManager() {
74 return tab_contents()->profile()->GetPrerenderManager(); 68 return tab_contents()->profile()->GetPrerenderManager();
(...skipping 10 matching lines...) Expand all
85 has_opener_set); 79 has_opener_set);
86 } 80 }
87 81
88 bool PrerenderObserver::IsPrerendering() { 82 bool PrerenderObserver::IsPrerendering() {
89 PrerenderManager* prerender_manager = MaybeGetPrerenderManager(); 83 PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
90 if (!prerender_manager) 84 if (!prerender_manager)
91 return false; 85 return false;
92 return prerender_manager->IsTabContentsPrerendering(tab_contents()); 86 return prerender_manager->IsTabContentsPrerendering(tab_contents());
93 } 87 }
94 88
89 void PrerenderObserver::PrerenderSwappedIn() {
90 // Ensure we are not prerendering any more.
91 DCHECK(!IsPrerendering());
92 if (pplt_load_start_.is_null()) {
93 // If we have already finished loading, report a 0 PPLT.
94 PrerenderManager::RecordPerceivedPageLoadTime(base::TimeDelta(),
95 tab_contents());
96 } else {
97 // If we have not finished loading yet, rebase the start time to now.
98 pplt_load_start_ = base::TimeTicks::Now();
99 }
100 }
101
95 } // namespace prerender 102 } // namespace prerender
OLDNEW
« no previous file with comments | « chrome/browser/prerender/prerender_observer.h ('k') | chrome/browser/prerender/prerender_render_view_host_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698