Support persistent incognito preferences

chrome/browser/extensions/extension_prefs_scope.h

Index: chrome/browser/extensions/extension_prefs_scope.h
diff --git a/chrome/browser/extensions/extension_prefs_scope.h b/chrome/browser/extensions/extension_prefs_scope.h
new file mode 100644
index 0000000000000000000000000000000000000000..9c331df4a076b0d7993dcbb6d2d4e4cb045dc78f
--- /dev/null
+++ b/chrome/browser/extensions/extension_prefs_scope.h
@@ -0,0 +1,23 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_SCOPE_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_SCOPE_H_
+#pragma once
+
+namespace extension_prefs_scope {

[Matt Perry, 2011/05/24 21:04:56]

This should not be a namespace. See this discussion on chromium-dev
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thre...

I'd say you can just make it a member of either the ExtensionPrefs or
ExtensionPrefValueMap class.

[battre, 2011/05/25 11:31:45]

Both would be a layering violation.
- ExtensionPrefValueMap is an implementation detail that should not be visible
to consumers of ExtensionPrefs.
- ExtensionPrefs on the other hand builds upon ExtensionPrefValueMap and
therefore should not be required for ExtensionPrefValueMap.

I have taken a note and propose to discuss this afterwards. After all it is just
an implementation detail that is not visible to the outside.

[Bernhard Bauer, 2011/05/25 17:48:34]

How about just calling it ExtensionPrefScope?

[Matt Perry, 2011/05/25 18:40:42]

Please add a TODO(battre) in that case.

[battre, 2011/05/25 19:47:44]

Done.

+
+// Scope for a preference.
+enum Scope {
+  // Regular profile.
+  kRegular,
+  // Incognito profile; preference is persisted to disk and remains active
+  // after a browser restart.
+  kIncognitoPersistent,
+  // TODO(battre): add kIncognitoSession
+};
+
+}  // extension_prefs_scope
+
+#endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_SCOPE_H_